From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C92672DBF47 for ; Mon, 12 Jan 2026 03:07:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768187267; cv=none; b=MxQ6Zv6acN/cKZNddwBjp1TO27iSp/B2f4CSG2VBtFaPUY3QYRIUwp/RvuFZcrK5h6V7vrtQNu8n8bATTPmxu9GClxC5yHahS32g2oGQWM/nc64dWZe/kZ6HRChz+SO0HC6+78wBv4ULnOz2c3sDKakuXsf8oHDPXhYYSEI6lmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768187267; c=relaxed/simple; bh=xIWxF8qqcTSw5yf5KjNsxJ+3DWBHl5QbBXmqPKxqAPo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M8nKmnNW4d3HtjujLFEYen2aL/lQVPBJesY/0vpeqCOqoxSNVFxXwPkbknWlY0U0C+2nP2m9FaSM/3oJ2dmFhEgrIBXmkdUsOVVHcZaq4Ia0wCnT1gTeykezX9RC9dX6XQW3k92djrseZrPOZBUNTT+4LPwvc54KN9VN40P/uzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=itTJ8ncR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DN+kpY0m; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="itTJ8ncR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DN+kpY0m" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60C0FIIa3849825 for ; Mon, 12 Jan 2026 03:07:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /++Xx/yBXksYUFw+xHC/+ucGThZ3NK28ihDy9joDCww=; b=itTJ8ncRIEe/TEhU dkFkltjxY5ratlnXCL9IMQA0MXAT8AtQl2PfJ8SE+xS5bHiltosJXGGHv3+u6qR+ NMVhJ1eojn9zzqlmXMP4tNG9b1uTt6jOlvEjOWKLU/sCiN+sJlP1Jpfx5WMX4HHY wM2ERD4M1DldtrwOIf8RfU5Lgjl6HVoIITNTOqvl2BPtJgG27h1U0a6twRt+YLpH saHSav8cRn1TdvTKBZZGbducIJ//PoCW+/Hax4C1NHWJwz4lp3xgYSdzbJJU0E+j R0pXDIEvXqItDCHXZX4J4J+Ci73b/Ol9wOZ9TA8sqwoSLVL8sOSzGiEIkbaOtUZF Y0Sqxg== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bks25af7y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 12 Jan 2026 03:07:46 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-88a2cc5b548so124329196d6.0 for ; Sun, 11 Jan 2026 19:07:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768187265; x=1768792065; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/++Xx/yBXksYUFw+xHC/+ucGThZ3NK28ihDy9joDCww=; b=DN+kpY0meJZhj9mAEDmz9OKp9cZSBluF7aBQwdXSGLIbY3kdLTssF4h8tQjU2p38PL apvcRy/gEzDvS02Oa0kfqAcz45ZGSOvx4YX15MiX/d24pUVO4+GyJysj1gmX/qkGt3B+ VI7kEvEKiT608kuHqF07QsxgctXM3TvAVgjLJd16NDYNc5HR+5xseapfsf1C6H6DZUd5 rlPUsC2GnSecZe84sBHjZQIEN/AIDlFJvWyiLA+ZMYSWXI/OXHnm/g3ZwxU/bo1XZ5y+ 8AIsLJfV3w5Y2KiVGx/Tw+mrB1o6V3dYgf8X1px1ri2zeT7Rk9jLv4LE80XAiaN3DEon W6vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768187265; x=1768792065; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/++Xx/yBXksYUFw+xHC/+ucGThZ3NK28ihDy9joDCww=; b=YUXObZYxXzEOequCxV0zIz8av3WQBZ/2DiXfcT8yo6qSCQOS3SksXZW5HfrqWz15fo QwXjHpfo31/3d4ZvtxTIaGLuJqRO26Gj7blhes9miMIeFt1FwxBw0LDvkkxECmiCTUnA dC7F6J1tEj3pGOpRIkNuJ/+ffeMkjuxtnpmnuaASoLRt7b1R5NlYVayC/6MrvmEdcKB+ Ej3r92+kgtFMMfksBrHKS9ZFXfowX0ZURvkzeTv7q0L5cc/ichtW9iI41jPHo5uO1bnd y8ioqH1JFsUZUBnFf6AqCpD2vEQB34WaHg1gLW2Cbe/hxwmXDHnOGe7zteR8b49EL5T6 Utew== X-Forwarded-Encrypted: i=1; AJvYcCX8oARoM9XDb4YPIcOcdlacDGFbCeacfQ9xvhHMhySpQe+k9g1w0KIuiBYEFeZWy7bg5Hp+wZwNXUqDcmA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxf9xXmLguD2r+CC0XKt6SgmLth/3dGfZbyxPzmfcVug3/Xk5Tu +zt/JJeqpYZM4M42sAlG0o+Ht+Gll3xSbqJR+QRJRCSV2gZgzfvuYVNgw9bXRGnhFyfHdzk5i0s ZlqGBI045cfPoP+3gaxK/JI9lDvNDggef6EaW6/Tdgj7MBDsssTpbPt4L19al3b0au/o= X-Gm-Gg: AY/fxX6UD3350w5MhYwPo5JwuuG5fMYG4MA27rAAc/tsQASF6Pn4GC+M8sUfOaGJw/k otChvcKjFiRcfzUGzxsV2prgmPthI1/1FP9WJ6Bdf/ItmVAabQrEqafaq9tgOp5cSoLNTfuBDuP C1kVwcN1r7hmoBj70t7gt+aCAvYQsDW/gDHvArD18CZ4yjGyuG2BX31K46bFMfTOHSZ/QgcaAhB J9t1UpLPg9KZyQKOWVuIuC7NH+zixCUh87qIU5pq42ZQLfcFRFk8RkCX6fJ9fxplbQ0QffON8tH mN9MMWl0Iu9MgHzEIB+93+RoeAFroOd0jC/l0X4AKzIp7I3NJxe7/nvUKJArDTHooqnap+RhyIP V5PKQ5aiQXcBjtS1WYBy7BSbQgZCHPysH7zej1rE+FPqXLdSPydibix0zkcrOTFc0ST/cC/Iw X-Received: by 2002:a05:6214:1c8a:b0:88a:355a:8d1f with SMTP id 6a1803df08f44-8907698fdd8mr308487676d6.8.1768187265192; Sun, 11 Jan 2026 19:07:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IFSEm5v201oW1/gAgQSazQnh4dS2BuTWE/iCazimW9e8H5+77G0//8vkZ3LsEjiZmN59LgYIg== X-Received: by 2002:a05:6214:1c8a:b0:88a:355a:8d1f with SMTP id 6a1803df08f44-8907698fdd8mr308487496d6.8.1768187264809; Sun, 11 Jan 2026 19:07:44 -0800 (PST) Received: from [10.111.167.32] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89077234405sm142792606d6.30.2026.01.11.19.07.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Jan 2026 19:07:44 -0800 (PST) Message-ID: <1344ad43-a4c4-4e37-ae4e-eddd2c577b3f@oss.qualcomm.com> Date: Mon, 12 Jan 2026 11:07:39 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] media: i2c: imx412: wait for NVM read (T7) before programming mode registers To: Bryan O'Donoghue , sakari.ailus@linux.intel.com, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260109044913.3310-1-wenmeng.liu@oss.qualcomm.com> Content-Language: en-US From: Wenmeng Liu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEyMDAyNCBTYWx0ZWRfX4ymB1mphHMtx X4yrJzFV/BNSfSMHgIyS8Gn0Ftcgtof3BUk0K6mfDY9JTKcAnloK7aCy33+kpt7FkahVljtmi2X pPtmUtkkWO7x/wO/2Eq6mnnsj4pvfW7+zvoWE6GX6X4Gx+YLnZEBU8uwS9XDSY/fZNjdAR1LP9y ophahOyhrANW2JgpQ+SrwtoX6/oSJ0BaC2lxDp2oCgS75N+pF+tIj8spBoL4+CHsRP4O6Pum7Xa LMw3bOU2BJxs13R3i4Ucy2BQsgE3rwD6mLVOqjzK54iiLwagVvfYxDPzTUKGIWo3AzdATCl+SrP HQlVLtFY0nnHmyKIWr/yn+hCuLKQFmHdh5YdcPQLetsI8+S7y0qmsuUFR4KnzQrchSLgdinnVd7 k92WEMRpsm+tYZh/RQpKbF0ruJqEqiNvFn23p5pYxFF+OP1VtighEnOQ1sOhuhxisZG6w9rXFrK QhclDgtLsdW8qzDCHnA== X-Proofpoint-GUID: l1on2hihBRkxyFbC7crU3WEiluVp8KqL X-Proofpoint-ORIG-GUID: l1on2hihBRkxyFbC7crU3WEiluVp8KqL X-Authority-Analysis: v=2.4 cv=EMELElZC c=1 sm=1 tr=0 ts=69646582 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=1tItfX1d1ggIHMnC-N4A:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-11_09,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 malwarescore=0 adultscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601120024 On 1/9/2026 8:32 PM, Bryan O'Donoghue wrote: > This delay should go at the end of the operation that requires the delay > not at the start of the streaming operation. > > The delay after the stream write, should be related to the stream write > command, not the antecedent - the command that came before start_streaming. > > Basically I think you need to put your delay into the CCI_ID read NVM > parameter load routine so that it guarantees its own completion. > > Because for argument's sake if start_streaming() were not to be the > thing to happen after CCI_ID/NVM loading, the logic would no longer work. > > And you need a Fixes: tag for this patch too. Reading the sensor ID only occurs during the sensor probe process. After the probe is completed, the IMX577 will power down. When stream on occurs, the driver will power on again and then start streaming, but the sensor ID is not read during the stream on process.I have tested this change on imx577 modules of different models. So this change can only happen during power on or stream on. Hi Bryan, Sakari, May I ask if you have any suggestions regarding this? Thanks, Wenmeng