From: Matt Fleming <matt.fleming@intel.com>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: Seiji Aguchi <seiji.aguchi@hds.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"Thomas Gleixner (tglx@linutronix.de)" <tglx@linutronix.de>,
"'mingo@elte.hu' (mingo@elte.hu)" <mingo@elte.hu>,
"olof@lixom.net" <olof@lixom.net>,
"Paul Gortmaker (paul.gortmaker@windriver.com)"
<paul.gortmaker@windriver.com>,
"dle-develop@lists.sourceforge.net"
<dle-develop@lists.sourceforge.net>,
Satoru Moriya <satoru.moriya@hds.com>,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [RESEND][PATCH]efi: initialize efi.runtime_version to make query_variable_info/update_capsule workable
Date: Fri, 17 Aug 2012 11:31:33 +0100 [thread overview]
Message-ID: <1345199493.3088.24.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <502D6982.4090100@linux.intel.com>
On Thu, 2012-08-16 at 14:43 -0700, H. Peter Anvin wrote:
> On 08/16/2012 12:53 AM, Matt Fleming wrote:
> > On Mon, 2012-08-06 at 18:37 +0000, Seiji Aguchi wrote:
> >> A value of efi.runtime_version is checked before calling
> >> update_capsule()/query_variable_info() as follows.
> >> But it isn't initialized anywhere.
> >> <snip>
> >> static efi_status_t virt_efi_query_variable_info(u32 attr,
> >> u64 *storage_space,
> >> u64 *remaining_space,
> >> u64 *max_variable_size) {
> >> if (efi.runtime_version < EFI_2_00_SYSTEM_TABLE_REVISION)
> >> return EFI_UNSUPPORTED;
> >> <snip>
> >>
> >> This patch initializes a value of efi.runtime_version at boot time.
> >>
> >> Acked-by: Matthew Garrett <mjg@redhat.com>
> >> Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
> >> ---
> >> arch/x86/platform/efi/efi.c | 1 +
> >> 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > Thanks, I picked this up just so it doesn't get lost. It will probably
> > go to Linus via Peter Anvin.
> >
>
> Should I take that as an Acked-by: on your part?
Yep.
prev parent reply other threads:[~2012-08-17 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 18:37 Seiji Aguchi
2012-08-16 7:53 ` Matt Fleming
2012-08-16 21:43 ` H. Peter Anvin
2012-08-17 10:31 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345199493.3088.24.camel@mfleming-mobl1.ger.corp.intel.com \
--to=matt.fleming@intel.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=hpa@linux.intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mjg59@srcf.ucam.org \
--cc=olof@lixom.net \
--cc=paul.gortmaker@windriver.com \
--cc=satoru.moriya@hds.com \
--cc=seiji.aguchi@hds.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome