From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
Jim Cromie <jim.cromie@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Kay Sievers <kay@vrfy.org>,
Jason Baron <jbaron@redhat.com>
Subject: Re: [bisected] Driver core fixes for 3.6-rc3 regression
Date: Sat, 18 Aug 2012 11:37:05 -0700 [thread overview]
Message-ID: <1345315025.10014.15.camel@joe2Laptop> (raw)
In-Reply-To: <20120818163401.GA2013@kroah.com>
On Sat, 2012-08-18 at 09:34 -0700, Greg KH wrote:
> On Sat, Aug 18, 2012 at 08:09:34AM +0200, Markus Trippelsdorf wrote:
> > On 2012.08.17 at 10:13 -0700, Greg KH wrote:
> > > ----------------------------------------------------------------
> > > Driver core fixes for 3.6-rc3
> > >
> > > Here are two tiny patches, one fixing a dynamic debug problem that the printk
> > > rework turned up, and the other one fixing an extcon problem that people
> > > reported.
> > >
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >
> > > ----------------------------------------------------------------
> > > Axel Lin (1):
> > > extcon: extcon_gpio: Replace gpio_request_one by devm_gpio_request_one
> > >
> > > Jim Cromie (1):
> > > drivers-core: make structured logging play nice with dynamic-debug
> >
> > The commit af7f2158f above causes hundreds of "Failed to force enable
> > HPET" messages to appear during boot on my system.
> > Please also note the strange "^A0" character sequence that is also
> > introduced by the same commit.
>
> Ugh, I see the same thing here, debugging must be accidentally enabled
> with this patch, and the ^A0 stuff is just a mess. Sorry, I didn't
> notice this in my testing, my fault.
It's a combination interaction because of the patch with
a conversion of KERN_<LEVEL> from "<.>" to concatenated
SOH "."
commit: 04d2c8c83d0e3ac5f78aeede51babb3236200112
> Reverting this resolves the issue for me.
>
> Jim, any thoughts on how to fix this? Should I just revert this patch
> for now?
I have a patch to resolve dynamic debug logging.
I'll submit it Monday along with an updated netdev_printk patch.
Joe
next prev parent reply other threads:[~2012-08-18 18:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 17:13 [GIT PATCH] Driver core fixes for 3.6-rc3 Greg KH
2012-08-18 6:09 ` [bisected] Driver core fixes for 3.6-rc3 regression Markus Trippelsdorf
2012-08-18 16:34 ` Greg KH
2012-08-18 18:37 ` Joe Perches [this message]
2012-08-18 18:55 ` Markus Trippelsdorf
2012-08-18 19:24 ` Linus Torvalds
2012-08-18 19:32 ` Markus Trippelsdorf
2012-08-19 0:08 ` Linus Torvalds
2012-08-19 5:57 ` Markus Trippelsdorf
2012-08-19 6:14 ` Greg KH
2012-08-19 6:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345315025.10014.15.camel@joe2Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@redhat.com \
--cc=jim.cromie@gmail.com \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®