mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCHSET 0/7] Cleanup hist printing code (v3)
Date: Mon, 20 Aug 2012 13:52:04 +0900	[thread overview]
Message-ID: <1345438331-20234-1-git-send-email-namhyung@kernel.org> (raw)

Hello,

This is a cleanup and refactoring patchset for the hist printing code
by adding hist_period_print functions and hpp_context.  I believe it
makes the code easy to maintain and to add new functionalities like
upcoming group viewing and callchain accumulation.

Any comments are welcome, thanks.
Namhyung

v2 -> v3:
 * Rebase to current acme/perf/core
 * Move fprintf code to ui/stdio/hist.c (Arnaldo)
 * Add ack from Pekka


Namhyung Kim (7):
  perf hists: Separate out hist print functions
  perf hists: Refactor some functions
  perf hists: Introduce hist_period_print functions
  perf hists: Handle field separator properly
  perf hists: Use hpp_functions->width to calculate the column widths
  perf ui/browser: Use hist_period_print functions
  perf gtk/browser: Use hist_period_print functions

 tools/perf/Makefile            |   5 +-
 tools/perf/builtin-diff.c      |   1 +
 tools/perf/ui/browsers/hists.c |  96 ++++--
 tools/perf/ui/gtk/browser.c    | 101 +++++-
 tools/perf/ui/gtk/gtk.h        |   1 +
 tools/perf/ui/gtk/setup.c      |   1 +
 tools/perf/ui/hist.c           | 391 +++++++++++++++++++++++
 tools/perf/ui/setup.c          |   8 +-
 tools/perf/ui/stdio/hist.c     | 498 +++++++++++++++++++++++++++++
 tools/perf/ui/tui/setup.c      |   4 +
 tools/perf/util/hist.c         | 710 ++---------------------------------------
 tools/perf/util/hist.h         |  43 ++-
 12 files changed, 1121 insertions(+), 738 deletions(-)
 create mode 100644 tools/perf/ui/hist.c
 create mode 100644 tools/perf/ui/stdio/hist.c

-- 
1.7.11.2


             reply	other threads:[~2012-08-20  4:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20  4:52 Namhyung Kim [this message]
2012-08-20  4:52 ` [PATCH 1/7] perf hists: Separate out hist print functions Namhyung Kim
2012-08-21 16:34   ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-08-20  4:52 ` [PATCH 2/7] perf hists: Refactor some functions Namhyung Kim
2012-08-21 16:34   ` [tip:perf/core] perf hists: Rename and move " tip-bot for Namhyung Kim
2012-08-20  4:52 ` [PATCH 3/7] perf hists: Introduce hist_period_print functions Namhyung Kim
2012-08-20 13:08   ` Arnaldo Carvalho de Melo
2012-08-21  8:05     ` Namhyung Kim
2012-08-20  4:52 ` [PATCH 4/7] perf hists: Handle field separator properly Namhyung Kim
2012-08-20  4:52 ` [PATCH 5/7] perf hists: Use hpp_functions->width to calculate the column widths Namhyung Kim
2012-08-20  4:52 ` [PATCH 6/7] perf ui/browser: Use hist_period_print functions Namhyung Kim
2012-08-20  4:52 ` [PATCH 7/7] perf gtk/browser: " Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345438331-20234-1-git-send-email-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome