mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: H Peter Anvin <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	Asit K Mallick <asit.k.mallick@intel.com>,
	Tigran Aivazian <tigran@aivazian.fsnet.co.uk>,
	Andreas Herrmann <andreas.herrmann3@amd.com>,
	Borislav Petkov <borislav.petkov@amd.com>,
	linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH 11/11] x86/Kconfig: Configurations to enable/disable the feature
Date: Mon, 20 Aug 2012 23:41:20 +0200	[thread overview]
Message-ID: <1345498880.18442.33.camel@x61.thuisdomein> (raw)
In-Reply-To: <1345277729-8399-12-git-send-email-fenghua.yu@intel.com>

Fenghua,

I have a few comments, that were triggered by scanning just this patch
(they also assume I remember the kconfig language correctly).

On Sat, 2012-08-18 at 01:15 -0700, Fenghua Yu wrote:
> From: Fenghua Yu <fenghua.yu@intel.com>
> 
> MICROCODE_INTEL_LIB, MICROCODE_INTEL_EARLY, and MICROCODE_EARLY are three new
> configurations to enable or disable the feature.
> 
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> ---
>  arch/x86/Kconfig |   22 ++++++++++++++++++++++
>  1 files changed, 22 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 50c660d..32caa77 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1035,6 +1035,7 @@ config MICROCODE_INTEL
>  	depends on MICROCODE
>  	default MICROCODE
>  	select FW_LOADER
> +	select MICROCODE_INTEL_LIB

MICROCODE_INTEL_LIB depends on MICROCODE_INTEL_EARLY.
MICROCODE_INTEL_EARLY itself also selects MICROCODE_INTEL_LIB. So can't
this kconfig entry be made to select MICROCODE_INTEL_EARLY instead?

If it can't select MICROCODE_INTEL_EARLY (because of that symbol's
dependency on BLK_DEV_INITRD) it seems this select could be dropped.

>  	---help---
>  	  This options enables microcode patch loading support for Intel
>  	  processors.
> @@ -1055,6 +1056,27 @@ config MICROCODE_OLD_INTERFACE
>  	def_bool y
>  	depends on MICROCODE
>  
> +config MICROCODE_EARLY
> +	def_bool y
> +	depends on MICROCODE_INTEL_EARLY
> +

MICROCODE_INTEL_EARLY selects this kconfig symbol. Doesn't that mean
that this entry can be simplified to:
    config MICROCODE_EARLY
        bool

> +config MICROCODE_INTEL_LIB
> +	def_bool y
> +	depends on MICROCODE_INTEL_EARLY

If MICROCODE_INTEL could be made to select MICROCODE_INTEL_EARLY (see
above) it seems this could also be shortened:
    config MICROCODE_INTEL_LIB
        bool

> +config MICROCODE_INTEL_EARLY
> +	bool "Early load microcode"
> +	depends on MICROCODE_INTEL && BLK_DEV_INITRD

If MICROCODE_INTEL could be made to select this kconfig symbol than the
dependency on MICROCODE_INTEL could be dropped. But the dependency on
BLK_DEV_INITRD might make that impossible.

> +	default y
> +	select FW_LOADER
> +	select MICROCODE_EARLY
> +	select MICROCODE_INTEL_LIB
> +	help
> +	  This option provides functionality to read additional microcode data
> +	  at the beginning of initrd image. The data tells kernel to load
> +	  microcode to CPU's as early as possible. No functional change if no
> +	  microcode data is glued to the initrd, therefore it's safe to say Y.
> +
>  config X86_MSR
>  	tristate "/dev/cpu/*/msr - Model-specific register support"
>  	---help---


Paul Bolle


  reply	other threads:[~2012-08-20 21:41 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-18  8:15 [PATCH 00/11] x86/microcode: Early load microcode Fenghua Yu
2012-08-18  8:15 ` [PATCH 01/11] Documentation/x86: " Fenghua Yu
2012-08-20 12:26   ` Borislav Petkov
2012-08-18  8:15 ` [PATCH 02/11] x86/lib/cpio.c: Find cpio data by its file name Fenghua Yu
2012-08-18 22:12   ` Henrique de Moraes Holschuh
2012-08-18 23:23     ` Yu, Fenghua
2012-08-19  4:35       ` Henrique de Moraes Holschuh
2012-08-19  5:15         ` H. Peter Anvin
2012-08-20 13:29   ` Borislav Petkov
2012-08-18  8:15 ` [PATCH 03/11] x86/microcode_intel.h: Define functions and macros for early load ucode Fenghua Yu
2012-08-20 13:47   ` Borislav Petkov
2012-08-18  8:15 ` [PATCH 04/11] x86/microcode_core_early.c: Define interfaces " Fenghua Yu
2012-08-18 22:44   ` Henrique de Moraes Holschuh
2012-08-19  2:38     ` Yu, Fenghua
2012-08-19  4:43       ` Henrique de Moraes Holschuh
2012-08-19  5:24       ` H. Peter Anvin
2012-08-19 16:39         ` Yu, Fenghua
2012-08-20 14:06           ` Borislav Petkov
2012-08-20 20:08             ` H. Peter Anvin
2012-08-20 20:19               ` Borislav Petkov
2012-08-21 20:05                 ` Yu, Fenghua
2012-08-21 20:13                   ` H. Peter Anvin
2012-08-21 20:48                     ` Borislav Petkov
2012-08-21 20:52                       ` H. Peter Anvin
2012-08-21 20:52                       ` Yu, Fenghua
2012-08-21 20:53                         ` H. Peter Anvin
2012-08-21 20:58                           ` Yu, Fenghua
2012-08-20 14:04   ` Borislav Petkov
2012-08-18  8:15 ` [PATCH 05/11] x86/microcode_intel_lib.c: Early update ucode on Intel's CPU Fenghua Yu
2012-08-20 15:31   ` Borislav Petkov
2012-08-20 16:24     ` Borislav Petkov
2012-08-18  8:15 ` [PATCH 06/11] x86/microcode_intel_early.c: " Fenghua Yu
2012-08-18  8:15 ` [PATCH 07/11] x86/head_32.S: Early update ucode in 32-bit Fenghua Yu
2012-08-18  8:15 ` [PATCH 08/11] x86/head64.c: Early update ucode in 64-bit Fenghua Yu
2012-08-18  8:15 ` [PATCH 09/11] x86/smpboot.c: Early update ucode on AP Fenghua Yu
2012-08-18  8:15 ` [PATCH 10/11] x86/mm/init.c: Copy ucode from initrd image to memory Fenghua Yu
2012-08-18  8:15 ` [PATCH 11/11] x86/Kconfig: Configurations to enable/disable the feature Fenghua Yu
2012-08-20 21:41   ` Paul Bolle [this message]
2012-08-20 15:39 ` [PATCH 00/11] x86/microcode: Early load microcode Borislav Petkov
2012-08-20 15:44   ` Yu, Fenghua
2012-08-20 18:51   ` H. Peter Anvin
2012-08-20 20:04     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345498880.18442.33.camel@x61.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=andreas.herrmann3@amd.com \
    --cc=asit.k.mallick@intel.com \
    --cc=borislav.petkov@amd.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=tigran@aivazian.fsnet.co.uk \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®