mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Chen Liqin <liqin.chen@sunplusct.com>,
	Lennox Wu <lennox.wu@gmail.com>, "3.2.x.." <stable@kernel.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH 09/10] score: Add missing RCU idle APIs on idle loop
Date: Wed, 22 Aug 2012 18:23:47 +0200	[thread overview]
Message-ID: <1345652628-15060-10-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1345652628-15060-1-git-send-email-fweisbec@gmail.com>

In the old times, the whole idle task was considered
as an RCU quiescent state. But as RCU became more and
more successful overtime, some RCU read side critical
section have been added even in the code of some
architectures idle tasks, for tracing for example.

So nowadays, rcu_idle_enter() and rcu_idle_exit() must
be called by the architecture to tell RCU about the part
in the idle loop that doesn't make use of rcu read side
critical sections, typically the part that puts the CPU
in low power mode.

This is necessary for RCU to find the quiescent states in
idle in order to complete grace periods.

Add this missing pair of calls in the scores's idle loop.

Reported-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Chen Liqin <liqin.chen@sunplusct.com>
Cc: Lennox Wu <lennox.wu@gmail.com>
Cc: 3.2.x.. <stable@kernel.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
 arch/score/kernel/process.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/score/kernel/process.c b/arch/score/kernel/process.c
index 2707023..637970c 100644
--- a/arch/score/kernel/process.c
+++ b/arch/score/kernel/process.c
@@ -27,6 +27,7 @@
 #include <linux/reboot.h>
 #include <linux/elfcore.h>
 #include <linux/pm.h>
+#include <linux/rcupdate.h>
 
 void (*pm_power_off)(void);
 EXPORT_SYMBOL(pm_power_off);
@@ -50,9 +51,10 @@ void __noreturn cpu_idle(void)
 {
 	/* endless idle loop with no priority at all */
 	while (1) {
+		rcu_idle_enter();
 		while (!need_resched())
 			barrier();
-
+		rcu_idle_exit();
 		schedule_preempt_disabled();
 	}
 }
-- 
1.7.5.4


  parent reply	other threads:[~2012-08-22 16:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-22 16:23 [PATCH 00/10] rcu: " Frederic Weisbecker
2012-08-22 16:23 ` [PATCH 01/10] alpha: " Frederic Weisbecker
2012-08-22 17:19   ` Paul E. McKenney
2012-08-22 17:35     ` Frederic Weisbecker
2012-08-22 19:01       ` Paul E. McKenney
2012-08-23 10:42         ` Frederic Weisbecker
2012-08-23 12:25           ` Paul E. McKenney
2012-08-23  9:32   ` Michael Cree
2012-08-23 10:58     ` Frederic Weisbecker
2012-08-22 16:23 ` [PATCH 02/10] cris: " Frederic Weisbecker
2012-08-22 16:23 ` [PATCH 03/10] frv: " Frederic Weisbecker
2012-08-22 16:23 ` [PATCH 04/10] h8300: " Frederic Weisbecker
2012-08-22 16:23 ` [PATCH 05/10] m32r: " Frederic Weisbecker
2012-08-22 16:23 ` [PATCH 06/10] m68k: " Frederic Weisbecker
2012-08-22 16:23 ` [PATCH 07/10] mn10300: " Frederic Weisbecker
2012-08-22 16:23 ` [PATCH 08/10] parisc: " Frederic Weisbecker
2012-08-24 13:26   ` John David Anglin
2012-08-22 16:23 ` Frederic Weisbecker [this message]
2012-08-22 16:23 ` [PATCH 10/10] xtensa: " Frederic Weisbecker
2012-08-22 17:18 ` [PATCH 00/10] rcu: " Geert Uytterhoeven
2012-08-23 11:02   ` Frederic Weisbecker
2012-08-23 20:23     ` Geert Uytterhoeven
2012-08-23 21:50       ` Frederic Weisbecker
2012-09-17 20:31         ` Geert Uytterhoeven
2012-09-17 20:55           ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345652628-15060-10-git-send-email-fweisbec@gmail.com \
    --to=fweisbec@gmail.com \
    --cc=lennox.wu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liqin.chen@sunplusct.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome