From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753976Ab2HWUKI (ORCPT ); Thu, 23 Aug 2012 16:10:08 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:6174 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581Ab2HWUKF (ORCPT ); Thu, 23 Aug 2012 16:10:05 -0400 X-Authority-Analysis: v=2.0 cv=cpwZYiEi c=1 sm=0 a=rXTBtCOcEpjy1lPqhTCpEQ==:17 a=mNMOxpOpBa8A:10 a=NWjVo0iC6IQA:10 a=5SG0PmZfjMsA:10 a=Q9fys5e9bTEA:10 a=cFw1Tl46iYYA:10 a=meVymXHHAAAA:8 a=pGLkceISAAAA:8 a=2HSo9kcaQ3Q_U7YvlDkA:9 a=PUjeQqilurYA:10 a=MSl-tDqOz04A:10 a=rXTBtCOcEpjy1lPqhTCpEQ==:117 X-Cloudmark-Score: 0 X-Originating-IP: 74.67.115.198 Message-ID: <1345752601.12440.3.camel@gandalf.local.home> Subject: Re: [PATCH] kconfig: replace 'oldnoconfig' with 'olddefconfig', what it really does From: Steven Rostedt To: Adam Lee Cc: linux-kernel@vger.kernel.org, Michal Marek , Yaakov Selkowitz , Peter Foley , Paul Bolle , "Eric W. Biederman" , "open list:KCONFIG" Date: Thu, 23 Aug 2012 16:10:01 -0400 In-Reply-To: <1345187778-19678-1-git-send-email-adam8157@gmail.com> References: <1345187778-19678-1-git-send-email-adam8157@gmail.com> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.4.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry for the late reply. On Fri, 2012-08-17 at 15:16 +0800, Adam Lee wrote: > As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, 'oldnoconfig' doesn't > set new symbols to 'n', but instead sets it to their default values. > > So, this patch replace 'oldnoconfig' with 'olddefconfig', stop making > people confused. > > PS: the document in conf.c fixed in another mail, "[PATCH] [Signed-off] > kconfig: document oldnoconfig to what it really does in conf.c" The reason that I didn't make this change myself is that I'm afraid that things depend on 'oldnoconfig' existing. For example, ktest.pl has it hardcoded. That may not be the only script that uses it. I think a better solution would be to make oldnoconfig do just that, set everything to 'n' as the name implies, and we can create a olddefconfig to do what it does now. -- Steve > > Signed-off-by: Adam Lee > --- > scripts/kconfig/Makefile | 6 +++--- > scripts/kconfig/conf.c | 18 +++++++++--------- > tools/testing/ktest/ktest.pl | 15 +++++++-------- > 3 files changed, 19 insertions(+), 20 deletions(-) >