From: Toshi Kani <toshi.kani@hp.com>
To: wim@iguana.be, linux-watchdog@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, thomas.mingarelli@hp.com,
Toshi Kani <toshi.kani@hp.com>,
stable@vger.kernel.org
Subject: [PATCH] hpwdt: Fix kdump issue in hpwdt
Date: Mon, 27 Aug 2012 12:52:24 -0600 [thread overview]
Message-ID: <1346093544-12007-1-git-send-email-toshi.kani@hp.com> (raw)
kdump can be interrupted by watchdog timer when the timer is left
activated on the crash kernel. Changed the hpwdt driver to disable
watchdog timer at boot-time. This assures that watchdog timer is
disabled until /dev/watchdog is opened, and prevents watchdog timer
to be left running on the crash kernel.
Signed-off-by: Toshi Kani <toshi.kani@hp.com>
Tested-by: Lisa Mitchell <lisa.mitchell@hp.com>
Cc: stable@vger.kernel.org
---
drivers/watchdog/hpwdt.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index 1eff743..ae60406 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -814,6 +814,9 @@ static int __devinit hpwdt_init_one(struct pci_dev *dev,
hpwdt_timer_reg = pci_mem_addr + 0x70;
hpwdt_timer_con = pci_mem_addr + 0x72;
+ /* Make sure that timer is disabled until /dev/watchdog is opened */
+ hpwdt_stop();
+
/* Make sure that we have a valid soft_margin */
if (hpwdt_change_timer(soft_margin))
hpwdt_change_timer(DEFAULT_MARGIN);
--
1.7.7.6
next reply other threads:[~2012-08-27 18:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 18:52 Toshi Kani [this message]
2012-08-27 18:59 ` Mingarelli, Thomas
2012-08-27 19:22 ` Lars Marowsky-Bree
2012-08-27 19:57 ` Mingarelli, Thomas
2012-08-27 20:44 ` Toshi Kani
2012-09-10 18:48 ` Wim Van Sebroeck
2012-09-10 18:48 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346093544-12007-1-git-send-email-toshi.kani@hp.com \
--to=toshi.kani@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thomas.mingarelli@hp.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®