From: Laxman Dewangan <ldewangan@nvidia.com>
To: <broonie@opensource.wolfsonmicro.com>, <sameo@linux.intel.com>,
<lrg@ti.com>
Cc: <swarren@wwwdotorg.com>, <linux-kernel@vger.kernel.org>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: [PATCH] regulator: tps65910: register regulator even if no init data
Date: Tue, 28 Aug 2012 15:59:27 +0530 [thread overview]
Message-ID: <1346149767-31602-2-git-send-email-ldewangan@nvidia.com> (raw)
In-Reply-To: <1346149767-31602-1-git-send-email-ldewangan@nvidia.com>
Register all TPS65910 regulators even if there is no regulator
init data for platform i.e. without any user-supplied constraints.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
This patch make sure that all chip regulators get registered
even there is no user-supplied.
This is based on discussion on following patch about registering
rails without init data.
max8907: fix use of possibly NULL idata
drivers/regulator/tps65910-regulator.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c
index 793adda..1f758c9 100644
--- a/drivers/regulator/tps65910-regulator.c
+++ b/drivers/regulator/tps65910-regulator.c
@@ -1105,11 +1105,6 @@ static __devinit int tps65910_probe(struct platform_device *pdev)
reg_data = pmic_plat_data->tps65910_pmic_init_data[i];
- /* Regulator API handles empty constraints but not NULL
- * constraints */
- if (!reg_data)
- continue;
-
/* Register the regulators */
pmic->info[i] = info;
--
1.7.1.1
next prev parent reply other threads:[~2012-08-28 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 10:29 [PATCH] regulator: tps6586x: " Laxman Dewangan
2012-08-28 10:29 ` Laxman Dewangan [this message]
2012-08-28 14:18 ` Stephen Warren
2012-08-28 14:56 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346149767-31602-2-git-send-email-ldewangan@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=swarren@wwwdotorg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome