From: Guenter Roeck <linux@roeck-us.net>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Ingo Molnar <mingo@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Jean Delvare <khali@linux-fr.org>,
lm-sensors@lm-sensors.org, Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH v2 1/2] linux/kernel.h: Introduce IDIV_ROUND_CLOSEST
Date: Tue, 28 Aug 2012 09:30:55 -0700 [thread overview]
Message-ID: <1346171456-29255-1-git-send-email-linux@roeck-us.net> (raw)
DIV_ROUND_CLOSEST returns a bad result for negative dividends:
DIV_ROUND_CLOSEST(-2, 2) = 0
Most of the time this does not matter. However, in the hardware monitoring
subsystem, it is sometimes used on integers which can be negative (such as
temperatures). Introduce new macro IDIV_ROUND_CLOSEST which also supports
negative dividends.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
v2: v1 did not work if typeof(divisor) was an unsigned variable type
(which can obviously not be negative).
Rework to revert to DIV_ROUND_CLOSEST if the dividend is unsigned,
or if it is signed but non-negative.
Plan is to merge this patch through my hwmon tree unless there is an objection.
include/linux/kernel.h | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 6043821..42f1fd6 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -89,6 +89,16 @@
} \
)
+#define IDIV_ROUND_CLOSEST(x, divisor)( \
+{ \
+ typeof(x) __x = x; \
+ typeof(divisor) __d = divisor; \
+ (((typeof(x))-1) >= 0 || (__x) >= 0) ? \
+ DIV_ROUND_CLOSEST((__x), (__d)) : \
+ (((__x) - ((__d) / 2)) / (__d)); \
+} \
+)
+
/*
* Multiplies an integer by a fraction, while avoiding unnecessary
* overflow or loss of precision.
--
1.7.9.7
next reply other threads:[~2012-08-28 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 16:30 Guenter Roeck [this message]
2012-08-28 16:30 ` [PATCH 2/2] hwmon: Use IDIV_ROUND_CLOSEST if the dividend can be negative Guenter Roeck
2012-08-30 23:15 ` [PATCH v2 1/2] linux/kernel.h: Introduce IDIV_ROUND_CLOSEST Andrew Morton
2012-08-30 23:50 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346171456-29255-1-git-send-email-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mingo@kernel.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®