From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.136 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795084880; b=LiMwwxqF12ReJysFMB0dazy0PqImQse8ZNMxbWvfAFwxMA/mV1Xd8BMQD49FQNiA64X+ x1mLaOBYD3vhR0xZATCWUgWAdfVps86VTJicqy4n06ZQBokLH2XYtpwM2kQgnnemKMWJw TPcTvvhROpwBZNQ6fyLEXD0xtku0JPn2PFE4vQlkJQt9KEZQu9pLhhFI7qF/1GriE6Cvq f0zJvF33pG0st9k5ecrGXrkP06bmrSMS0HprS2/pjlSjVnLH6uhoQSt/tWC/aPCMpwh3y jmeC3ekNgkH7VpNEDL/ms1TuXINLWdNxUrx5evcrXLX6tcsLqgMMrqjr3jRGzzEOmag== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795084880; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=SqewZBuM8W9dFnIHmwbhkjA1res2Yb2Puzim9ot0z7Q=; b=v3VrGoZWJrMvWlftQzmbpCITNnI2EbwceL+DPKPAk9hN1txYjfnJXXCiDNb++Kq9O8uG dSSQBLST4vtY0gQ5ennQBzVJwb3SvK2IWP2jsoWgMWL0Kv5nZNWoHFR9gNZrbexi/cQ6P 8cBDd2fwrzcLk0BmORhXMc/P2S2+2onxUxLs6UvPbMyNMCwCNSqEG9duQ8mVZFBtTd86V nGRxk1lHZo2vKbhn8XLkRwYjl3Gfb8xR9yy4DepWCGPObXp0HwhNoeM+OBLd2ZITJg/d2 +G0iaBNFVW6z+wN2HzhIGa/cg9qrJcgwWagbN++UKo+TbyxMzUvO9w8N8EG9ATq9FVQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=BXvKnVwq; arc=none smtp.remote-ip=91.218.175.136 Received: from mta0.migadu.com (out-136.mta0.migadu.com [91.218.175.136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16EEF606A320 for ; Thu, 19 Nov 2026 10:41:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 16EEF606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=BXvKnVwq X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=hHV4wmzRo7/QebuMoNM7638o7gz26MY6+dWlsZX3ePM=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795084877; v=1; x=1795689677; b=BXvKnVwqbBXBF/S2cqOFQ6NvWmItsmp+bSF/X4MnyqKqrAnfGJPTYxwJ9VBOjX1hBeot7mSI Kq3e8H+mtmOBFbuhDhXciM0EvtOdd4YBFsuz9hM4R/QjIX6lNQVISu7UGRoun9rikn4ynC4/Yze vhqw4jcbqHLQadVdyV/lWEg8= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id d7dbceaa39de39d7; Thu, 19 Nov 2026 10:41:17 +0000 X-Mizu-Trace-ID: d7dbceaa39de39d7 X-Migadu-Flow: FLOW_OUT Message-ID: <13462768-b7c2-4049-8e0e-44bd1e0fd659@linux.dev> Date: Thu, 19 Nov 2026 11:35:57 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: Override Intel Apollo Lake audio class on Gauteng W3S laptops [8086:5a98] To: Steven 'Steve' Kendall , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Takashi Iwai , linux-sound@vger.kernel.org References: <20261119-gauteng-audio-class-set-v1-1-e81d6fd620ad@chromium.org> Content-Language: en-US From: Pierre-Louis Bossart In-Reply-To: <20261119-gauteng-audio-class-set-v1-1-e81d6fd620ad@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/19/26 01:52, Steven 'Steve' Kendall wrote: > Gauteng Education Dept MODEL-W3S laptops advertise PCI class 0x040300 > to use the legacy HDA driver rather than the Audio DSP on the Intel > Apollo Lake audio controller ([8086:5a98]). However, this board uses an > I2S ES8336 codec with no analog HDA codec, and its firmware otherwise > sets up the hardware to enable the DSP. > > Add a PCI header fixup for [8086:5a98] on Gauteng W3S systems to > override class 0x040300 to 0x040100 so the SOF driver can claim the > device. Notably this fixes the internal speakers and headphones but > not jack detection. > > This patch and its initial changelog were generated by Gemini during > an interactive debugging session given dmesg, lspci and similar > dumps from Gauteng W3S and MODEL-W3S laptops. The resulting quirk > was reviewed and tested on physical MODEL-W3S hardware and on a W3S > with slightly different hardware. > > Signed-off-by: Steven 'Steve' Kendall > --- > drivers/pci/quirks.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c Humm, this sort of quirks is usually in sound/hda/core/intel-dsp-config.c. I don't think we've ever touched drivers/pci/quirks.c for DSP-related changes, did we? And last you could do this driver selection with the kernel parameter snd_intel_dspcfg.dsp_driver=2. > index 7f1f47ea2ee4..908d038fa29a 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -754,6 +754,40 @@ DECLARE_PCI_FIXUP_CLASS_HEADER(PCI_VENDOR_ID_SYNOPSYS, PCI_ANY_ID, > PCI_CLASS_SERIAL_USB_XHCI, 0, > quirk_synopsys_haps); > > +/* > + * Gauteng Education Dept MODEL-W3S laptops report PCI class 0x040300 > + * (PCI_CLASS_MULTIMEDIA_HD_AUDIO) on the Apollo Lake audio controller > + * ([8086:5a98]) even though the Audio DSP (BAR 4), NHLT ACPI table, and I2S > + * ESSX8336 codec are enabled and no analog HDA codec is present. > + * > + * Override the class to 0x040100 (PCI_CLASS_MULTIMEDIA_AUDIO << 8) so SOF can > + * claim the device. > + */ > +static const struct dmi_system_id gauteng_w3s_dmi_table[] = { > + { > + .ident = "Gauteng Education Dept W3S", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Gauteng Education Dept"), > + DMI_MATCH(DMI_PRODUCT_NAME, "W3S"), > + } > + }, > + {} > +}; > + > +static void quirk_gauteng_w3s_audio_class(struct pci_dev *pdev) > +{ > + u32 class = pdev->class; > + > + if (dmi_check_system(gauteng_w3s_dmi_table)) { > + pdev->class = PCI_CLASS_MULTIMEDIA_AUDIO << 8; > + pci_info(pdev, FW_BUG "PCI class overridden (%#08x -> %#08x) so SOF driver can claim this instead of snd_hda_intel\n", > + class, pdev->class); > + } also is SOF really used for an ApolloLake product? I thought all SOF-based Chromebooks started with GeminiLake?