mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
	josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de,
	peterz@infradead.org, rostedt@goodmis.org,
	Valdis.Kletnieks@vt.edu, dhowells@redhat.com,
	eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com,
	sbw@mit.edu, patches@linaro.org,
	"Paul E. McKenney" <paul.mckenney@linaro.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 26/26] ia64: Add missing RCU idle APIs on idle loop
Date: Thu, 30 Aug 2012 14:05:43 -0700	[thread overview]
Message-ID: <1346360743-3628-26-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <1346360743-3628-1-git-send-email-paulmck@linux.vnet.ibm.com>

From: "Paul E. McKenney" <paul.mckenney@linaro.org>

Traditionally, the entire idle task served as an RCU quiescent state.
But when RCU read side critical sections started appearing within the
idle loop, this traditional strategy became untenable.  The fix was to
create new RCU APIs named rcu_idle_enter() and rcu_idle_exit(), which
must be called by each architecture's idle loop so that RCU can tell
when it is safe to ignore a given idle CPU.

Unfortunately, this fix was never applied to ia64, a shortcoming remedied
by this commit.

Reported by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Tested by: Tony Luck <tony.luck@intel.com>
---
 arch/ia64/kernel/process.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/ia64/kernel/process.c b/arch/ia64/kernel/process.c
index dd6fc14..3e316ec 100644
--- a/arch/ia64/kernel/process.c
+++ b/arch/ia64/kernel/process.c
@@ -29,6 +29,7 @@
 #include <linux/kdebug.h>
 #include <linux/utsname.h>
 #include <linux/tracehook.h>
+#include <linux/rcupdate.h>
 
 #include <asm/cpu.h>
 #include <asm/delay.h>
@@ -279,6 +280,7 @@ cpu_idle (void)
 
 	/* endless idle loop with no priority at all */
 	while (1) {
+		rcu_idle_enter();
 		if (can_do_pal_halt) {
 			current_thread_info()->status &= ~TS_POLLING;
 			/*
@@ -309,6 +311,7 @@ cpu_idle (void)
 			normal_xtp();
 #endif
 		}
+		rcu_idle_exit();
 		schedule_preempt_disabled();
 		check_pgt_cache();
 		if (cpu_is_offline(cpu))
-- 
1.7.8


  parent reply	other threads:[~2012-08-30 21:14 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-30 21:05 [PATCH tip/core/rcu 0/26] idle-related changes Paul E. McKenney
2012-08-30 21:05 ` [PATCH tip/core/rcu 01/26] rcu: New rcu_user_enter() and rcu_user_exit() APIs Paul E. McKenney
2012-08-30 21:05   ` [PATCH tip/core/rcu 02/26] rcu: New rcu_user_enter_irq() and rcu_user_exit_irq() APIs Paul E. McKenney
2012-08-31 19:13     ` Josh Triplett
2012-08-31 19:54       ` Frederic Weisbecker
2012-08-31 21:38         ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 03/26] rcu: Make RCU_FAST_NO_HZ handle adaptive ticks Paul E. McKenney
2012-08-31 23:40     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 04/26] rcu: Settle config for userspace extended quiescent state Paul E. McKenney
2012-08-31 23:44     ` Josh Triplett
2012-09-05  0:34       ` Paul E. McKenney
2012-09-05  0:46         ` Josh Triplett
2012-09-10 21:35           ` Frederic Weisbecker
2012-08-30 21:05   ` [PATCH tip/core/rcu 05/26] rcu: Allow rcu_user_enter()/exit() to nest Paul E. McKenney
2012-08-31 23:45     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 06/26] rcu: Ignore userspace extended quiescent state by default Paul E. McKenney
2012-08-31 23:46     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 07/26] rcu: Switch task's syscall hooks on context switch Paul E. McKenney
2012-08-31 23:48     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 08/26] x86: Syscall hooks for userspace RCU extended QS Paul E. McKenney
2012-08-31 23:59     ` Josh Triplett
2012-09-10 21:30       ` Frederic Weisbecker
2012-08-30 21:05   ` [PATCH tip/core/rcu 09/26] x86: Exception " Paul E. McKenney
2012-08-31 23:51     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 10/26] rcu: Exit RCU extended QS on kernel preemption after irq/exception Paul E. McKenney
2012-08-31 23:51     ` Josh Triplett
2012-09-06 16:52     ` Peter Zijlstra
2012-09-10 20:31       ` Frederic Weisbecker
2012-08-30 21:05   ` [PATCH tip/core/rcu 11/26] rcu: Exit RCU extended QS on user preemption Paul E. McKenney
2012-08-31 23:52     ` Josh Triplett
2012-09-06 17:02     ` Peter Zijlstra
2012-09-06 17:13       ` Peter Zijlstra
2012-09-10 20:26         ` Frederic Weisbecker
2012-09-12  9:33           ` Peter Zijlstra
2012-09-12 12:06             ` Frederic Weisbecker
2012-09-12 12:41               ` Peter Zijlstra
2012-09-12 12:52                 ` Peter Zijlstra
2012-09-12 13:54                   ` Frederic Weisbecker
2012-09-12 14:09                     ` Peter Zijlstra
2012-09-12 13:52                 ` Frederic Weisbecker
2012-09-12 15:21                 ` Paul E. McKenney
2012-08-30 21:05   ` [PATCH tip/core/rcu 12/26] x86: Use the new schedule_user API on userspace preemption Paul E. McKenney
2012-08-31 23:53     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 13/26] x86: Exit RCU extended QS on notify resume Paul E. McKenney
2012-08-31 23:54     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 14/26] rcu: Userspace RCU extended QS selftest Paul E. McKenney
2012-08-31 23:54     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 15/26] alpha: Fix preemption handling in idle loop Paul E. McKenney
2012-08-31 23:55     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 16/26] alpha: Add missing RCU idle APIs on " Paul E. McKenney
2012-09-01  0:00     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 17/26] cris: " Paul E. McKenney
2012-09-01  0:01     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 18/26] frv: " Paul E. McKenney
2012-09-01  0:01     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 19/26] h8300: " Paul E. McKenney
2012-09-01  0:02     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 20/26] m32r: " Paul E. McKenney
2012-09-01  0:02     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 21/26] m68k: " Paul E. McKenney
2012-09-01  0:02     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 22/26] mn10300: " Paul E. McKenney
2012-09-01  0:03     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 23/26] parisc: " Paul E. McKenney
2012-09-01  0:03     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 24/26] score: " Paul E. McKenney
2012-09-01  0:04     ` Josh Triplett
2012-08-30 21:05   ` [PATCH tip/core/rcu 25/26] xtensa: " Paul E. McKenney
2012-09-01  0:05     ` Josh Triplett
2012-08-30 21:05   ` Paul E. McKenney [this message]
2012-09-01  0:05     ` [PATCH tip/core/rcu 26/26] ia64: " Josh Triplett
2012-08-31 19:07   ` [PATCH tip/core/rcu 01/26] rcu: New rcu_user_enter() and rcu_user_exit() APIs Josh Triplett
2012-09-05  1:04     ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346360743-3628-26-git-send-email-paulmck@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=darren@dvhart.com \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=eric.dumazet@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mingo@elte.hu \
    --cc=niv@us.ibm.com \
    --cc=patches@linaro.org \
    --cc=paul.mckenney@linaro.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sbw@mit.edu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®