mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cruz Julian Bishop <cruzjbishop@gmail.com>
To: mcgrof@gmail.com
Cc: linux-kernel@vger.kernel.org, Cruz Julian Bishop <cruzjbishop@gmail.com>
Subject: [PATCH 1/4] scripts/checkincludes.pl: Print usage with heredoc
Date: Fri, 31 Aug 2012 23:18:07 +1000	[thread overview]
Message-ID: <1346419090-3808-2-git-send-email-cruzjbishop@gmail.com> (raw)
In-Reply-To: <1346419090-3808-1-git-send-email-cruzjbishop@gmail.com>

This is already used in checkpatch.pl, and is easier to
read, so I am changing it in checkincludes as well.

Additionally, this makes the usage output theoretically
easier to edit. In practise, there's almost no difference

Signed-off-by: Cruz Julian Bishop <cruzjbishop@gmail.com>
---
 scripts/checkincludes.pl |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/scripts/checkincludes.pl b/scripts/checkincludes.pl
index 97b2c61..801ed5f 100755
--- a/scripts/checkincludes.pl
+++ b/scripts/checkincludes.pl
@@ -14,9 +14,13 @@
 use strict;
 
 sub usage {
-	print "Usage: checkincludes.pl [-r]\n";
-	print "By default we just warn of duplicates\n";
-	print "To remove duplicated includes in place use -r\n";
+	print <<EOM;
+Usage: checkincludes.pl [OPTIONS]... FILE...
+By default, we just warn of duplicates.
+
+Options:
+  -r                Remove duplicated includes in place
+EOM
 	exit 1;
 }
 
-- 
1.7.9.5


  reply	other threads:[~2012-08-31 13:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-31 13:18 [PATCH 0/4] scripts/checkpatch.pl: A small step for Linux Cruz Julian Bishop
2012-08-31 13:18 ` Cruz Julian Bishop [this message]
2012-08-31 13:18 ` [PATCH 2/4] scripts/checkincludes.pl: Simplify and shorten argument logic Cruz Julian Bishop
2012-08-31 15:42   ` Joe Perches
2012-08-31 21:54     ` Cruz Julian Bishop
2012-08-31 13:18 ` [PATCH 3/4] scripts/checkincludes.pl: Fix a bug introduced in the last commit Cruz Julian Bishop
2012-08-31 13:18 ` [PATCH 4/4] scripts/checkincludes.pl: Introduce 'quiet' mode Cruz Julian Bishop
2012-08-31 13:23 ` [PATCH 0/4] scripts/checkpatch.pl: A small step for Linux Cruz Julian Bishop
2012-08-31 18:09 ` Jesper Juhl
2012-08-31 21:55   ` Cruz Julian Bishop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346419090-3808-2-git-send-email-cruzjbishop@gmail.com \
    --to=cruzjbishop@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®