From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755853Ab2ICDAs (ORCPT ); Sun, 2 Sep 2012 23:00:48 -0400 Received: from LGEMRELSE7Q.lge.com ([156.147.1.151]:64143 "EHLO LGEMRELSE7Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754457Ab2ICDAr (ORCPT ); Sun, 2 Sep 2012 23:00:47 -0400 X-AuditID: 9c930197-b7b93ae0000028a7-df-50441d5dd412 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Paul Mackerras , Ingo Molnar , LKML Subject: [PATCHSET RESEND 0/5] perf tools: Cleanup hist printing code (v4) Date: Mon, 3 Sep 2012 11:53:05 +0900 Message-Id: <1346640790-17197-1-git-send-email-namhyung@kernel.org> X-Mailer: git-send-email 1.7.11.4 X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This is a cleanup and refactoring patchset for the hist printing code by adding perf_hpp__format functions and perf_hpp. I believe it makes the code easy to maintain and to add new features like upcoming group viewing and callchain accumulation. Any comments are welcome, thanks. Namhyung v3 -> v4: * Rebase to current acme/perf/core * The first two in the previous series have been merged * Rename hist_period_print to perf_hpp_fmt (Arnaldo) * Rename ctx->s to hpp->buf (Arnaldo) v2 -> v3: * Move fprintf code to ui/stdio/hist.c (Arnaldo) * Add ack from Pekka Namhyung Kim (5): perf hists: Introduce perf_hpp for hist period printing perf hists: Handle field separator properly perf hists: Use perf_hpp__format->width to calculate the column widths perf ui/browser: Use perf_hpp__format functions perf gtk/browser: Use perf_hpp__format functions tools/perf/Makefile | 2 + tools/perf/builtin-diff.c | 1 + tools/perf/ui/browsers/hists.c | 94 ++++++++--- tools/perf/ui/gtk/browser.c | 101 ++++++++++-- tools/perf/ui/gtk/gtk.h | 1 + tools/perf/ui/gtk/setup.c | 1 + tools/perf/ui/hist.c | 366 +++++++++++++++++++++++++++++++++++++++++ tools/perf/ui/setup.c | 8 +- tools/perf/ui/stdio/hist.c | 239 +++++---------------------- tools/perf/ui/tui/setup.c | 4 + tools/perf/util/hist.c | 33 ---- tools/perf/util/hist.h | 37 +++++ 12 files changed, 616 insertions(+), 271 deletions(-) create mode 100644 tools/perf/ui/hist.c -- 1.7.11.4