From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757420Ab2IDQOy (ORCPT ); Tue, 4 Sep 2012 12:14:54 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:52034 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757280Ab2IDQOv (ORCPT ); Tue, 4 Sep 2012 12:14:51 -0400 From: Peter Senna Tschudin To: Mauro Carvalho Chehab Cc: kernel-janitors@vger.kernel.org, Julia.Lawall@lip6.fr, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] drivers/media/platform/vino.c: fix error return code Date: Tue, 4 Sep 2012 18:14:26 +0200 Message-Id: <1346775269-12191-2-git-send-email-peter.senna@gmail.com> X-Mailer: git-send-email 1.7.11.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // Signed-off-by: Peter Senna Tschudin --- drivers/media/platform/vino.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/vino.c b/drivers/media/platform/vino.c index cc9110c..6654a28 100644 --- a/drivers/media/platform/vino.c +++ b/drivers/media/platform/vino.c @@ -2061,6 +2061,7 @@ static int vino_capture_next(struct vino_channel_settings *vcs, int start) } if (incoming == 0) { dprintk("vino_capture_next(): no buffers available\n"); + err = -ENOMEM; goto out; }