mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ABI: sysfs-class-hwmon: fix tempY_crit_alarm access rights
Date: Sat, 18 Nov 2023 09:47:08 -0800	[thread overview]
Message-ID: <1346aeac-ccda-43fd-8a63-0c843bfe33b9@roeck-us.net> (raw)
In-Reply-To: <20231116-hwmon_abi-v1-3-8bfb7f51145a@gmail.com>

On Fri, Nov 17, 2023 at 07:40:36AM +0100, Javier Carrasco wrote:
> This attribute is defined as read-only by all drivers that support it.
> 
> It seems that the access rights and description for this attribute were
> copied from the intrusionY_alarm, which has indeed RW rights and must be
> cleared by the user.
> 
> These are the modules that currently use this attribute:
> - adt7x10
> - i5500_temp
> - jc42
> - lm83
> - lm90
> - lm95245
> - max31760
> - max6621
> - mc34vr500
> - tmp401
> - tmp464
> - tmp513
> 
> Fix the attribute description and make it read-only.
> 
> Fixes: 365b5d63a505 ("ABI: sysfs-class-hwmon: add a description for tempY_crit_alarm")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

Applied.

Thanks,
Guenter

  reply	other threads:[~2023-11-18 17:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17  6:40 [PATCH 0/4] ABI: sysfs-class-hwmon: document existing attributes Javier Carrasco
2023-11-17  6:40 ` [PATCH 1/4] ABI: sysfs-class-hwmon: rearrange humidity attributes alphabetically Javier Carrasco
2023-11-18 17:45   ` Guenter Roeck
2023-11-17  6:40 ` [PATCH 2/4] ABI: sysfs-class-hwmon: document missing humidity attributes Javier Carrasco
2023-11-18 17:46   ` Guenter Roeck
2023-11-17  6:40 ` [PATCH 3/4] ABI: sysfs-class-hwmon: fix tempY_crit_alarm access rights Javier Carrasco
2023-11-18 17:47   ` Guenter Roeck [this message]
2023-11-17  6:40 ` [PATCH 4/4] ABI: sysfs-class-hwmon: document emergency/max/min temperature alarms Javier Carrasco
2023-11-18 17:47   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346aeac-ccda-43fd-8a63-0c843bfe33b9@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®