From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756356Ab2IGSdf (ORCPT ); Fri, 7 Sep 2012 14:33:35 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:40537 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753163Ab2IGSdb (ORCPT ); Fri, 7 Sep 2012 14:33:31 -0400 Subject: Re: [PATCH 06/11] target: go through normal processing for zero-length REQUEST_SENSE From: "Nicholas A. Bellinger" To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, target-devel@vger.kernel.org, hch@lst.de, roland@kernel.org In-Reply-To: <1347042182.4162.634.camel@haakon2.linux-iscsi.org> References: <1347031842-2531-1-git-send-email-pbonzini@redhat.com> <1347031842-2531-7-git-send-email-pbonzini@redhat.com> <1347042182.4162.634.camel@haakon2.linux-iscsi.org> Content-Type: text/plain; charset="UTF-8" Date: Fri, 07 Sep 2012 11:33:29 -0700 Message-ID: <1347042809.4162.640.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2012-09-07 at 11:23 -0700, Nicholas A. Bellinger wrote: > On Fri, 2012-09-07 at 17:30 +0200, Paolo Bonzini wrote: > > Now that spc_emulate_request_sense has been taught to process zero-length > > REQUEST SENSE correctly, drop the special handling of unit attention > > conditions from transport_generic_new_cmd. However, for now REQUEST SENSE > > will be the only command that goes through emulation for zero lengths. > > > > Signed-off-by: Paolo Bonzini > > --- > > drivers/target/target_core_transport.c | 8 +------- > > 1 files changed, 1 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c > > index 8facb74..09d9279 100644 > > --- a/drivers/target/target_core_transport.c > > +++ b/drivers/target/target_core_transport.c > > @@ -2301,6 +2301,7 @@ int transport_generic_new_cmd(struct se_cmd *cmd) > > * away. > > */ > > if (!cmd->data_length && > > + cmd->t_task_cdb[0] != REQUEST_SENSE && > > (cmd->se_dev->transport->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV || > > cmd->t_task_cdb[0] == REPORT_LUNS) { > > spin_lock_irq(&cmd->t_state_lock); Btw, this section does not compile. I'm squashing the following into your original patch. Let me know if you have any objections. Thanks Paolo! diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index cda32eb..269f544 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -2307,8 +2307,7 @@ int transport_generic_new_cmd(struct se_cmd *cmd) */ if (!cmd->data_length && cmd->t_task_cdb[0] != REQUEST_SENSE && - (cmd->se_dev->transport->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV || - cmd->t_task_cdb[0] == REPORT_LUNS) { + cmd->se_dev->transport->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV) { spin_lock_irq(&cmd->t_state_lock); cmd->t_state = TRANSPORT_COMPLETE; cmd->transport_state |= CMD_T_ACTIVE;