mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Irina Tirdea <irina.tirdea@gmail.com>
To: mingo@redhat.com, acme@ghostprotocols.net,
	a.p.zijlstra@chello.nl, rostedt@goodmis.org
Cc: paulus@samba.org, dsahern@gmail.com, namhyung.kim@lge.com,
	linux-kernel@vger.kernel.org,
	Irina Tirdea <irina.tirdea@intel.com>
Subject: [PATCH v2 11/12] perf tools: add NO_BACKTRACE for application self-debugging
Date: Sat,  8 Sep 2012 03:43:23 +0300	[thread overview]
Message-ID: <1347065004-15306-12-git-send-email-irina.tirdea@intel.com> (raw)
In-Reply-To: <1347065004-15306-1-git-send-email-irina.tirdea@intel.com>

From: Irina Tirdea <irina.tirdea@intel.com>

perf has support for self-debugging by defining dump_stack function. This
function uses backtrace and backtrace_symbols functions defined as GNU
extensions.

In Android, bionic does not offer support for these functions and compilation
will fail with the following error:
target  C: libperf <= tools/perf/util/util.c
tools/perf/util/util.c:4:22: fatal error: execinfo.h: No such file or directory
compilation terminated.

Add a compile-time option (NO_BACKTRACE) to enable or disable self-debugging
functionality in perf. This can also help in debugging since it offers the
possibility to turn on/off printing the backtrace.

Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
---
 tools/perf/Makefile                 |    8 ++++++++
 tools/perf/config/feature-tests.mak |   14 ++++++++++++++
 tools/perf/util/util.c              |    6 ++++++
 3 files changed, 28 insertions(+)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 25d2bab..c0d2ce3 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -756,6 +756,14 @@ else
 	endif
 endif
 
+ifdef NO_BACKTRACE
+       BASIC_CFLAGS += -DNO_BACKTRACE
+else
+       ifneq ($(call try-cc,$(SOURCE_BACKTRACE),),y)
+               BASIC_CFLAGS += -DNO_BACKTRACE
+       endif
+endif
+
 ifdef ASCIIDOC8
 	export ASCIIDOC8
 endif
diff --git a/tools/perf/config/feature-tests.mak b/tools/perf/config/feature-tests.mak
index 2f1156a..116690a 100644
--- a/tools/perf/config/feature-tests.mak
+++ b/tools/perf/config/feature-tests.mak
@@ -179,3 +179,17 @@ int main(void)
 }
 endef
 endif
+
+ifndef NO_BACKTRACE
+define SOURCE_BACKTRACE
+#include <execinfo.h>
+#include <stdio.h>
+
+int main(void)
+{
+	backtrace(NULL, 0);
+	backtrace_symbols(NULL, 0);
+	return 0;
+}
+endef
+endif
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index 1b8775c..2055cf3 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -1,7 +1,9 @@
 #include "../perf.h"
 #include "util.h"
 #include <sys/mman.h>
+#ifndef NO_BACKTRACE
 #include <execinfo.h>
+#endif
 #include <stdio.h>
 #include <stdlib.h>
 
@@ -163,6 +165,7 @@ size_t hex_width(u64 v)
 }
 
 /* Obtain a backtrace and print it to stdout. */
+#ifndef NO_BACKTRACE
 void dump_stack(void)
 {
 	void *array[16];
@@ -177,3 +180,6 @@ void dump_stack(void)
 
 	free(strings);
 }
+#else
+void dump_stack(void) {}
+#endif
-- 
1.7.9.5


  parent reply	other threads:[~2012-09-08  0:47 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-08  0:43 [PATCH v2 00/12] Porting perf to Android Irina Tirdea
2012-09-08  0:43 ` [PATCH v2 01/12] perf tools: include wrapper for magic.h Irina Tirdea
2012-09-08  9:13   ` Pekka Enberg
2012-09-08 22:39     ` Irina Tirdea
2012-09-08  0:43 ` [PATCH v2 02/12] perf tools: update types definitions for Android Irina Tirdea
2012-09-08  0:43 ` [PATCH v2 03/12] perf tools: include __WORDSIZE definition Irina Tirdea
2012-09-08  9:07   ` Pekka Enberg
2012-09-08 22:19     ` Irina Tirdea
2012-09-10 14:44       ` Peter Zijlstra
2012-09-10 21:42         ` Irina Tirdea
2012-09-08  0:43 ` [PATCH v2 04/12] perf tools: fix ALIGN redefinition in system headers Irina Tirdea
2012-09-08  0:43 ` [PATCH v2 05/12] perf tools: include basename for non-glibc systems Irina Tirdea
2012-09-08  9:09   ` Pekka Enberg
2012-09-08 14:33     ` David Ahern
2012-09-08 11:43   ` [tip:perf/core] " tip-bot for Irina Tirdea
2012-09-08  0:43 ` [PATCH v2 06/12] perf tools: fix missing winsize definition Irina Tirdea
2012-09-08 11:44   ` [tip:perf/core] " tip-bot for Irina Tirdea
2012-09-08  0:43 ` [PATCH v2 07/12] perf tools: include missing pthread.h header Irina Tirdea
2012-09-08 11:45   ` [tip:perf/core] " tip-bot for Irina Tirdea
2012-09-08  0:43 ` [PATCH v2 08/12] perf tools: fix no return in non-void function Irina Tirdea
2012-09-08  0:43 ` [PATCH v2 09/12] perf tools: replace mkostemp with mkstemp Irina Tirdea
2012-09-08 11:46   ` [tip:perf/core] " tip-bot for Irina Tirdea
2012-09-08  0:43 ` [PATCH v2 10/12] tools lib traceevent: replace mempcpy with memcpy Irina Tirdea
2012-09-08 11:47   ` [tip:perf/core] " tip-bot for Irina Tirdea
2012-09-08  0:43 ` Irina Tirdea [this message]
2012-09-08 11:48   ` [tip:perf/core] perf tools: add NO_BACKTRACE for application self-debugging tip-bot for Irina Tirdea
2012-09-08  0:43 ` [PATCH v2 12/12] perf tools: Use __maybe_used for unused variables Irina Tirdea
2012-09-08  1:14 ` [PATCH v2 00/12] Porting perf to Android Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347065004-15306-12-git-send-email-irina.tirdea@intel.com \
    --to=irina.tirdea@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=irina.tirdea@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®