mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: dave@gnu.org
Cc: lkml <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH] lib: gcd: prevent possible div by 0
Date: Mon, 10 Sep 2012 11:12:23 +0200	[thread overview]
Message-ID: <1347268343.1234.1307.camel@edumazet-glaptop> (raw)
In-Reply-To: <1347203038.3288.1.camel@offbook>

On Sun, 2012-09-09 at 17:03 +0200, Davidlohr Bueso wrote:
> Account for properties when a and/or b are 0:
> gcd(0, 0) = 0
> gcd(a, 0) = a
> gcd(0, b) = b
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> ---
>  lib/gcd.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/gcd.c b/lib/gcd.c
> index cce4f3c..7e163c6 100644
> --- a/lib/gcd.c
> +++ b/lib/gcd.c
> @@ -7,6 +7,9 @@ unsigned long gcd(unsigned long a, unsigned long b)
>  {
>  	unsigned long r;
>  
> +	if (!a || !b)
> +		return a | b;

This seems overkill

> +
>  	if (a < b)
>  		swap(a, b);

better here to :
	if (!b)
		return a;

>  	while ((r = a % b) != 0) {



  reply	other threads:[~2012-09-10  9:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-09 15:03 Davidlohr Bueso
2012-09-10  9:12 ` Eric Dumazet [this message]
2012-09-10 10:30   ` Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347268343.1234.1307.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave@gnu.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®