mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: linux-kernel@vger.kernel.org
Cc: linux-can@vger.kernel.org, sameo@linux.intel.com,
	"Ira W. Snyder" <iws@ovro.caltech.edu>
Subject: [PATCH 1/2] mfd/janz-cmodio: fix MODULBus number sysfs entry
Date: Tue, 11 Sep 2012 15:58:14 -0700	[thread overview]
Message-ID: <1347404295-7985-2-git-send-email-iws@ovro.caltech.edu> (raw)
In-Reply-To: <1347404295-7985-1-git-send-email-iws@ovro.caltech.edu>

From: "Ira W. Snyder" <iws@ovro.caltech.edu>

Revision 1.0 of the Janz CMOD-IO Carrier Board does not contain zeroes
in the top 4 bits of the modulbus_num (int_enable) register. Mask off
the unused bits so that the correct value is displayed in sysfs.

Cc: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
---
 drivers/mfd/janz-cmodio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/janz-cmodio.c b/drivers/mfd/janz-cmodio.c
index 2ea9998..32d0efd 100644
--- a/drivers/mfd/janz-cmodio.c
+++ b/drivers/mfd/janz-cmodio.c
@@ -216,7 +216,7 @@ static int __devinit cmodio_pci_probe(struct pci_dev *dev,
 	}
 
 	/* Read the hex switch on the carrier board */
-	priv->hex = ioread8(&priv->ctrl->int_enable);
+	priv->hex = ioread8(&priv->ctrl->int_enable) & 0x0f;
 
 	/* Add the MODULbus number (hex switch value) to the device's sysfs */
 	ret = sysfs_create_group(&dev->dev.kobj, &cmodio_sysfs_attr_group);
-- 
1.7.8.6


  reply	other threads:[~2012-09-11 22:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-11 22:58 [PATCH 0/2] janz: fix support for Janz CMOD-IO revision 1.0 hardware Ira W. Snyder
2012-09-11 22:58 ` Ira W. Snyder [this message]
2012-09-13 11:56   ` [PATCH 1/2] mfd/janz-cmodio: fix MODULBus number sysfs entry Marc Kleine-Budde
2012-09-13 12:52     ` Samuel Ortiz
2012-09-13 12:57       ` Marc Kleine-Budde
2012-09-11 22:58 ` [PATCH 2/2] can: janz-ican3: fix support for older hardware revisions Ira W. Snyder
2012-09-13 11:57   ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347404295-7985-2-git-send-email-iws@ovro.caltech.edu \
    --to=iws@ovro.caltech.edu \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®