mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Ezequiel Garcia <elezegarcia@gmail.com>
Cc: linux-kernel@vger.kernel.org, Pekka Enberg <penberg@kernel.org>,
	tim.bird@am.sony.com, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v3] trace: Move trace event enable from fs_initcall to core_initcall
Date: Wed, 12 Sep 2012 09:52:34 -0400	[thread overview]
Message-ID: <1347457954.10751.38.camel@gandalf.local.home> (raw)
In-Reply-To: <CALF0-+XxgMsQwwGaody0L5MTwpkDhqukbvzG2fUNsG1hEaREUw@mail.gmail.com>

On Wed, 2012-09-12 at 09:29 -0300, Ezequiel Garcia wrote:
> Steven,
> 
> On Tue, Sep 11, 2012 at 9:34 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> ble(void)
> [...]
> >> +     /*
> >> +      * Early initialization already enabled ftrace event.
> >> +      * Now it's only necessary to create the event directory.
> >> +      */
> >>       for_each_event(call, __start_ftrace_events, __stop_ftrace_events) {
> >> -             __trace_add_event_call(*call, NULL, &ftrace_event_id_fops,
> >
> > Here, __trace_add_event_call() did the checks and did not create a
> > directory on raw_init() failure. But now there's no check, and we are
> > having events being created that should not be.
> >
> 
> I believe the problem is we're iterating through every event
> defined in __start_ftrace_events.
> We should iterate through the events added to the ftrace_events list.

Yeah, that sounds like a better solution. I can't at the moment think of
anything where that would break.

Thanks,

-- Steve


      reply	other threads:[~2012-09-12 13:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-08 20:01 Ezequiel Garcia
2012-09-12  0:34 ` Steven Rostedt
2012-09-12  3:38   ` Ezequiel Garcia
2012-09-12 12:29   ` Ezequiel Garcia
2012-09-12 13:52     ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347457954.10751.38.camel@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=elezegarcia@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=penberg@kernel.org \
    --cc=tim.bird@am.sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®