mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Samuel Iglesias Gonsálvez" <siglesias@igalia.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	industrypack-devel@lists.sourceforge.net
Subject: Re: [PATCH 4/5] Staging: ipack/devices/ipoctal: acknowledge BREAK condition.
Date: Thu, 13 Sep 2012 12:07:40 +0200	[thread overview]
Message-ID: <1347530860.4539.217.camel@fourier.local.igalia.com> (raw)
In-Reply-To: <20120913100250.GM19396@mwanda>

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

On Thu, 2012-09-13 at 13:02 +0300, Dan Carpenter wrote:
> On Thu, Sep 13, 2012 at 11:46:27AM +0200, Samuel Iglesias Gonsalvez wrote:
> > Clear the BREAK flag from the ISR register.
> > 
> > Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
> 
> What are the user visible effects of this bugfix?
> 

It clears the BREAK flag in the device and avoid to read wrongly the
same condition later.

I should have described better this commit message. I will sent a second
version editing this commit message.

Thanks,

Sam


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2012-09-13 10:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13  9:46 [PATCH 1/5] Staging: ipack: Add IPACK_INT_SPACE memory space Samuel Iglesias Gonsalvez
2012-09-13  9:46 ` [PATCH 2/5] Staging: ipack: move the responsibility to clear interrupts to the IPack devices Samuel Iglesias Gonsalvez
2012-09-13  9:46 ` [PATCH 3/5] staging: ipack: remove irq field in struct ipack_device Samuel Iglesias Gonsalvez
2012-09-13 10:01   ` Dan Carpenter
2012-09-13 10:33     ` Samuel Iglesias Gonsálvez
2012-09-13  9:46 ` [PATCH 4/5] Staging: ipack/devices/ipoctal: acknowledge BREAK condition Samuel Iglesias Gonsalvez
2012-09-13 10:02   ` Dan Carpenter
2012-09-13 10:07     ` Samuel Iglesias Gonsálvez [this message]
2012-09-13  9:46 ` [PATCH 5/5] Staging: ipack/devices/ipoctal: simplify ipoctal_write_tty() Samuel Iglesias Gonsalvez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347530860.4539.217.camel@fourier.local.igalia.com \
    --to=siglesias@igalia.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=industrypack-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®