From: Gerald Schaefer <gerald.schaefer@de.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Gerald Schaefer <gerald.schaefer@de.ibm.com>
Subject: [PATCH] thp, s390: add missing earlyclobber to inline assembly
Date: Thu, 13 Sep 2012 16:21:03 +0200 [thread overview]
Message-ID: <1347546063-6337-1-git-send-email-gerald.schaefer@de.ibm.com> (raw)
In-Reply-To: <1346937043-28208-9-git-send-email-gerald.schaefer@de.ibm.com>
The constraints of the rrbm inline assembly are missing two
earlyclobber operands, which can lead to an addressing exception
depending on compiler register allocation decisions.
Signed-off-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
---
Hello Andrew, please merge this with patch
thp-s390-architecture-backend-for-thp-on-s390.patch
arch/s390/include/asm/pgtable.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h
index 1393a3c..ce67458 100644
--- a/arch/s390/include/asm/pgtable.h
+++ b/arch/s390/include/asm/pgtable.h
@@ -1296,7 +1296,8 @@ static inline int pmdp_test_and_clear_young(struct vm_area_struct *vma,
" ogr %1,%0\n"
" la %3,0(%4,%3)\n"
" brct %2,0b\n"
- : "=d" (tmp), "+d" (rc), "+d" (counter), "+a" (pmd_addr)
+ : "=&d" (tmp), "+&d" (rc), "+d" (counter),
+ "+a" (pmd_addr)
: "a" (64 * 4096UL) : "cc");
rc = !!rc;
} else {
--
1.7.11.6
prev parent reply other threads:[~2012-09-13 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 13:10 [PATCH 0/8] thp: transparent hugepages on s390 Gerald Schaefer
2012-09-06 13:10 ` [PATCH 1/8] thp, x86: introduce HAVE_ARCH_TRANSPARENT_HUGEPAGE Gerald Schaefer
2012-09-06 13:10 ` [PATCH 2/8] thp: remove assumptions on pgtable_t type Gerald Schaefer
2012-09-06 13:10 ` [PATCH 3/8] thp: introduce pmdp_invalidate() Gerald Schaefer
2012-09-06 13:10 ` [PATCH 4/8] thp: make MADV_HUGEPAGE check for mm->def_flags Gerald Schaefer
2012-09-06 13:10 ` [PATCH 5/8] thp, s390: thp splitting backend for s390 Gerald Schaefer
2012-09-06 13:10 ` [PATCH 6/8] thp, s390: thp pagetable pre-allocation " Gerald Schaefer
2012-09-06 13:10 ` [PATCH 7/8] thp, s390: disable thp for kvm host on s390 Gerald Schaefer
2012-09-06 13:10 ` [PATCH 8/8] thp, s390: architecture backend for thp " Gerald Schaefer
2012-09-13 14:21 ` Gerald Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347546063-6337-1-git-send-email-gerald.schaefer@de.ibm.com \
--to=gerald.schaefer@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome