From: Grant Likely <grant.likely@secretlab.ca>
To: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Grant Likely <grant.likely@secretlab.ca>,
Matthew Garrett <mjg@redhat.com>
Subject: [PATCH] gmux: Fix backlight set function
Date: Thu, 13 Sep 2012 21:02:35 +0100 [thread overview]
Message-ID: <1347566555-9388-1-git-send-email-grant.likely@secretlab.ca> (raw)
In commit 7e30ed6b, "gmux: Add generic write32 function", the new
gmux_write32() function didn't include the io offset when writing
registers. This means that backlight update writes never go to the right
place. This patch fixes it.
Tested on Apple Macbook 8,3
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Cc: Matthew Garrett <mjg@redhat.com>
---
drivers/platform/x86/apple-gmux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c
index dfb1a92..ee21056 100644
--- a/drivers/platform/x86/apple-gmux.c
+++ b/drivers/platform/x86/apple-gmux.c
@@ -101,7 +101,7 @@ static void gmux_pio_write32(struct apple_gmux_data *gmux_data, int port,
for (i = 0; i < 4; i++) {
tmpval = (val >> (i * 8)) & 0xff;
- outb(tmpval, port + i);
+ outb(tmpval, gmux_data->iostart + port + i);
}
}
--
1.7.9.5
next reply other threads:[~2012-09-13 20:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 20:02 Grant Likely [this message]
2012-09-13 20:26 ` Seth Forshee
2012-09-13 20:31 ` Matthew Garrett
2012-09-13 20:35 ` David Woodhouse
2012-09-14 13:06 ` Grant Likely
2012-09-17 9:37 ` David Woodhouse
2012-10-04 10:53 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347566555-9388-1-git-send-email-grant.likely@secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®