mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Michal Marek <mmarek@suse.cz>,
	linux-kbuild@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] add "enable" to the kconfig language
Date: Thu, 13 Sep 2012 21:49:55 -0400	[thread overview]
Message-ID: <1347587395.10751.88.camel@gandalf.local.home> (raw)
In-Reply-To: <20120914101414.1e24b28d2cfa8fc030952a58@canb.auug.org.au>

On Fri, 2012-09-14 at 10:14 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> I have noticed that we use the following paradigm quite a bit theses days:
> 
> config <something
> 	select HAVE_<config1>
> 
> config <config1>
> 	depends on HAVE_<config1>
> 
> or similar
> 
> I was wondering if it would make sense to replace this with:
> 
> config <something
> 	enable <config1>
> 
> config <config1>
> 	depends on enabled
> 
> The advantage of this is that we would not have all the HAVE_ config
> names in our .config files and the generated include files.  Of course,
> if config1 does not depend on "enabled", then the "enable <config1>"
> would have no effect (we may want to warn about this).
> 
> Comments?

I always hated those HAVE_* configs, especially because they were always
a source of confusion when asking someone if something is enabled...

Them: "The function tracer doesn't work, I don't see any debugfs files"

me: "Do you have FUNCTION_TRACER enabled?"

Them: "Yes, I checked"

me: "You have *FUNCTION_TRACER* not *HAVE_FUNCTION_TRACER*?"

Them: "Oh, no I just have HAVE_FUNCTION_TRACER"

BAH!

If you can make 'enable' work, I would definitely Ack converting over to
it.

-- Steve



      reply	other threads:[~2012-09-14  1:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14  0:14 Stephen Rothwell
2012-09-14  1:49 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347587395.10751.88.camel@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®