From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759184Ab2IND1b (ORCPT ); Thu, 13 Sep 2012 23:27:31 -0400 Received: from mga11.intel.com ([192.55.52.93]:34636 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755393Ab2IND13 (ORCPT ); Thu, 13 Sep 2012 23:27:29 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,420,1344236400"; d="scan'208";a="221883159" Subject: Re: [PATCH v2 04/15] dmaengine: Pass no_wakeup parameter via device_prep_dma_cyclic() callback From: Vinod Koul To: Peter Ujfalusi Cc: Mark Brown , Liam Girdwood , Tony Lindgren , Russell King , Dan Williams , Jarkko Nikula , alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Janusz Krzysztofik , Ricardo Neri , Lars-Peter Clausen , Nicolas Ferre , Barry Song , Srinidhi Kasagar , Russell King - ARM Linux , Vista Silicon , Zhangfei Gao , Shawn Guo , Laxman Dewangan In-Reply-To: <1347543485-339-5-git-send-email-peter.ujfalusi@ti.com> References: <1347543485-339-1-git-send-email-peter.ujfalusi@ti.com> <1347543485-339-5-git-send-email-peter.ujfalusi@ti.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 14 Sep 2012 08:54:00 +0530 Message-ID: <1347593040.1943.24.camel@vkoul-udesk3> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2012-09-13 at 16:37 +0300, Peter Ujfalusi wrote: > Change the parameter list of device_prep_dma_cyclic() so the DMA drivers > can receive the no_wakeup request coming from client drivers. > This feature can be used during audio operation to disable all audio > related interrupts. We already have a flag to indicate this, see * @DMA_PREP_INTERRUPT - trigger an interrupt (callback) upon completion of * this transaction Unfortunately, the addition of cyclic API missed having this flag. So right way would be to add flag argument in the API. -- ~Vinod