From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756095Ab2INNN0 (ORCPT ); Fri, 14 Sep 2012 09:13:26 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:39503 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752958Ab2INNNX (ORCPT ); Fri, 14 Sep 2012 09:13:23 -0400 Subject: RE: [PATCH] sch_red: fix weighted average calculation From: Eric Dumazet To: "Dowdal, John" Cc: "Chemparathy, Cyril" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "davem@davemloft.net" , "david.ward@ll.mit.edu" , "paul.gortmaker@windriver.com" In-Reply-To: <2D29FFBF554947468515B8EF6C733BB72E564F65@DLEE09.ent.ti.com> References: <1347543820-27548-1-git-send-email-cyril@ti.com> <1347544431.13103.1557.camel@edumazet-glaptop> <2D29FFBF554947468515B8EF6C733BB72E564F65@DLEE09.ent.ti.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 14 Sep 2012 15:13:16 +0200 Message-ID: <1347628396.26523.6.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2012-09-14 at 13:01 +0000, Dowdal, John wrote: > Eric, thank you for reviewing the code. I now see the problem with > the patch since backlog is an integer and qavg is a fixed point number > at logW. > > We are considering another patch to update the comments to this code > (with the actual C code change reverted) to stop the FPP by showing > the derivation of the equation in the comments. Does this sound good? This would be good, please do so. Thanks