From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756149Ab2IQN6i (ORCPT ); Mon, 17 Sep 2012 09:58:38 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:34074 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754643Ab2IQN6e (ORCPT ); Mon, 17 Sep 2012 09:58:34 -0400 From: Shubhrajyoti D To: CC: , , Shubhrajyoti D Subject: [PATCH 1/7] rtc: Convert struct i2c_msg initialization to C99 format Date: Mon, 17 Sep 2012 19:28:08 +0530 Message-ID: <1347890294-28467-2-git-send-email-shubhrajyoti@ti.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1347890294-28467-1-git-send-email-shubhrajyoti@ti.com> References: <1347890294-28467-1-git-send-email-shubhrajyoti@ti.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-ds1672.c | 26 ++++++++++++++++++++++---- 1 files changed, 22 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-ds1672.c b/drivers/rtc/rtc-ds1672.c index 7fa67d0..b44b2a1 100644 --- a/drivers/rtc/rtc-ds1672.c +++ b/drivers/rtc/rtc-ds1672.c @@ -37,8 +37,18 @@ static int ds1672_get_datetime(struct i2c_client *client, struct rtc_time *tm) unsigned char buf[4]; struct i2c_msg msgs[] = { - {client->addr, 0, 1, &addr}, /* setup read ptr */ - {client->addr, I2C_M_RD, 4, buf}, /* read date */ + { + .addr = client->addr, + .flags = 0, + .len = 1, + .buf = &addr + }, /* setup read ptr */ + { + .addr = client->addr, + .flags = I2C_M_RD, + .len = 4, + .buf = buf + }, /* read date */ }; /* read date registers */ @@ -99,8 +109,16 @@ static int ds1672_get_control(struct i2c_client *client, u8 *status) unsigned char addr = DS1672_REG_CONTROL; struct i2c_msg msgs[] = { - {client->addr, 0, 1, &addr}, /* setup read ptr */ - {client->addr, I2C_M_RD, 1, status}, /* read control */ + { .addr = client->addr, + .flags = 0, + .len = 1, + .buf = &addr + }, /* setup read ptr */ + { .addr = client->addr, + .flags = I2C_M_RD, + .len = 1, + .buf = status + }, /* read control */ }; /* read control register */ -- 1.7.5.4