From: Youquan Song <youquan.song@intel.com>
To: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
arjan@linux.intel.com, lenb@kernel.org
Cc: Rik van Riel <riel@redhat.com>,
Youquan Song <youquan.song@linux.intel.com>,
Youquan Song <youquan.song@intel.com>
Subject: [PATCH V2 3/3] x86,idle: Set residency to 0 if target Cstate not really enter
Date: Mon, 17 Sep 2012 21:53:29 -0400 [thread overview]
Message-ID: <1347933209-25939-4-git-send-email-youquan.song@intel.com> (raw)
In-Reply-To: <1347933209-25939-3-git-send-email-youquan.song@intel.com>
When cpuidle governor choose a C-state to enter for idle CPU, but it notice that
there is tasks request to be executed. So the idle CPU will not really enter
the target C-state and go to run task.
In this situation, it will use the residency of previous really entered target
C-states. Obviously, it is not reasonable.
So, this patch fix it by set the target C-state residency to 0.
Signed-off-by: Youquan Song <youquan.song@intel.com>
---
drivers/cpuidle/cpuidle.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 2f0083a..7992417 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -136,6 +136,10 @@ int cpuidle_idle_call(void)
/* ask the governor for the next state */
next_state = cpuidle_curr_governor->select(drv, dev);
if (need_resched()) {
+ dev->last_residency = 0;
+ /* give the governor an opportunity to reflect on the outcome */
+ if (cpuidle_curr_governor->reflect)
+ cpuidle_curr_governor->reflect(dev, next_state);
local_irq_enable();
return 0;
}
prev parent reply other threads:[~2012-09-17 13:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 1:53 [PATCH V2 0/3] x86,idle: Enhance cpuidle prediction to handle its failure Youquan Song
2012-09-17 14:52 ` Daniel Lezcano
2012-09-18 3:30 ` Youquan Song
2012-09-17 20:32 ` Daniel Lezcano
2012-09-18 1:53 ` [PATCH V2 1/3] x86,idle: Quickly notice prediction failure for repeat mode Youquan Song
2012-09-17 13:59 ` Rik van Riel
2012-09-18 2:15 ` Youquan Song
2012-09-18 1:53 ` [PATCH V2 2/3] x86,idle: Quickly notice prediction failure in general case Youquan Song
2012-09-18 1:53 ` Youquan Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347933209-25939-4-git-send-email-youquan.song@intel.com \
--to=youquan.song@intel.com \
--cc=arjan@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
--cc=youquan.song@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®