From: navin patidar <navinp@cdac.in>
To: gregkh@linuxfoundation.org, mfm@muteddisk.com
Cc: linux-usb@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, navin patidar <navinp@cdac.in>
Subject: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host
Date: Tue, 18 Sep 2012 09:30:06 +0530 [thread overview]
Message-ID: <1347940806-4653-1-git-send-email-navinp@cdac.in> (raw)
stub_device_reset should set kernel thread pointers to NULL.
so that at the time of usbip_host removal stub_shoutdown_connection
doesn't try to kill kernel threads which are already killed.
Signed-off-by: navin patidar <navinp@cdac.in>
---
drivers/staging/usbip/stub_dev.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c
index 92ced35..447a98c 100644
--- a/drivers/staging/usbip/stub_dev.c
+++ b/drivers/staging/usbip/stub_dev.c
@@ -198,10 +198,8 @@ static void stub_shutdown_connection(struct usbip_device *ud)
* tcp_socket is freed after threads are killed so that usbip_xmit does
* not touch NULL socket.
*/
- if (ud->tcp_socket) {
+ if (ud->tcp_socket)
sock_release(ud->tcp_socket);
- ud->tcp_socket = NULL;
- }
/* 3. free used data */
stub_device_cleanup_urbs(sdev);
@@ -233,6 +231,9 @@ static void stub_device_reset(struct usbip_device *ud)
dev_dbg(&udev->dev, "device reset");
+ ud->tcp_socket = NULL;
+ ud->tcp_rx = NULL;
+ ud->tcp_tx = NULL;
ret = usb_lock_device_for_reset(udev, sdev->interface);
if (ret < 0) {
dev_err(&udev->dev, "lock for reset\n");
--
1.7.9.5
next reply other threads:[~2012-09-18 4:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 4:00 navin patidar [this message]
2012-09-18 7:40 ` Dan Carpenter
2012-09-18 9:32 ` navin patidar
2012-09-18 9:36 ` Dan Carpenter
2012-09-18 11:44 ` navin patidar
2012-09-18 13:15 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2012-09-14 13:21 navin patidar
2012-09-14 14:16 ` Dan Carpenter
2012-09-14 14:28 ` Sebastian Andrzej Siewior
2012-09-14 14:41 ` Dan Carpenter
2012-09-14 9:53 navin patidar
2012-09-14 11:42 ` Sergei Shtylyov
2012-09-14 12:04 ` Sebastian Andrzej Siewior
2012-09-14 14:29 ` navin patidar
[not found] ` <CAPV97yfV27x8hB2WUCVmGWEU7i21Y5K5trig2fzQBx+VB_Yk2g@mail.gmail.com>
2012-09-14 14:16 ` Sergei Shtylyov
2012-09-17 12:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347940806-4653-1-git-send-email-navinp@cdac.in \
--to=navinp@cdac.in \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mfm@muteddisk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®