From: Thierry Reding <thierry.reding@avionic-design.de>
To: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: Qin Rui <qinrui@mprc.pku.edu.cn>, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/5] unicore32: pwm: Remove unnecessary indirection
Date: Tue, 18 Sep 2012 10:23:51 +0200 [thread overview]
Message-ID: <1347956633-15667-4-git-send-email-thierry.reding@avionic-design.de> (raw)
In-Reply-To: <1347956633-15667-1-git-send-email-thierry.reding@avionic-design.de>
Calling the actual probing function through a proxy isn't required and
makes the code needlessly complex.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
arch/unicore32/kernel/pwm.c | 23 ++++++-----------------
1 file changed, 6 insertions(+), 17 deletions(-)
diff --git a/arch/unicore32/kernel/pwm.c b/arch/unicore32/kernel/pwm.c
index 012c54a..7e23470 100644
--- a/arch/unicore32/kernel/pwm.c
+++ b/arch/unicore32/kernel/pwm.c
@@ -156,8 +156,7 @@ static inline void __add_pwm(struct pwm_device *pwm)
mutex_unlock(&pwm_lock);
}
-static struct pwm_device *pwm_probe(struct platform_device *pdev,
- unsigned int pwm_id, struct pwm_device *parent_pwm)
+static int __devinit pwm_probe(struct platform_device *pdev)
{
struct pwm_device *pwm;
struct resource *r;
@@ -166,7 +165,7 @@ static struct pwm_device *pwm_probe(struct platform_device *pdev,
pwm = kzalloc(sizeof(struct pwm_device), GFP_KERNEL);
if (pwm == NULL) {
dev_err(&pdev->dev, "failed to allocate memory\n");
- return ERR_PTR(-ENOMEM);
+ return -ENOMEM;
}
pwm->clk = clk_get(NULL, "OST_CLK");
@@ -177,7 +176,7 @@ static struct pwm_device *pwm_probe(struct platform_device *pdev,
pwm->clk_enabled = 0;
pwm->use_count = 0;
- pwm->pwm_id = pwm_id;
+ pwm->pwm_id = pdev->id;
pwm->pdev = pdev;
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
@@ -203,7 +202,7 @@ static struct pwm_device *pwm_probe(struct platform_device *pdev,
__add_pwm(pwm);
platform_set_drvdata(pdev, pwm);
- return pwm;
+ return 0;
err_release_mem:
release_mem_region(r->start, resource_size(r));
@@ -211,17 +210,7 @@ err_free_clk:
clk_put(pwm->clk);
err_free:
kfree(pwm);
- return ERR_PTR(ret);
-}
-
-static int __devinit puv3_pwm_probe(struct platform_device *pdev)
-{
- struct pwm_device *pwm = pwm_probe(pdev, pdev->id, NULL);
-
- if (IS_ERR(pwm))
- return PTR_ERR(pwm);
-
- return 0;
+ return ret;
}
static int __devexit pwm_remove(struct platform_device *pdev)
@@ -251,7 +240,7 @@ static struct platform_driver puv3_pwm_driver = {
.driver = {
.name = "PKUnity-v3-PWM",
},
- .probe = puv3_pwm_probe,
+ .probe = pwm_probe,
.remove = __devexit_p(pwm_remove),
};
module_platform_driver(puv3_pwm_driver);
--
1.7.12
next prev parent reply other threads:[~2012-09-18 8:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 8:23 [PATCH v2 0/5] unicore32: Move PWM driver to PWM framework Thierry Reding
2012-09-18 8:23 ` [PATCH v2 1/5] unicore32: pwm: Properly remap memory-mapped registers Thierry Reding
2012-09-18 8:23 ` [PATCH v2 2/5] unicore32: pwm: Use module_platform_driver() Thierry Reding
2012-09-22 2:56 ` guanxuetao
2012-09-22 7:32 ` Thierry Reding
2012-09-22 10:49 ` guanxuetao
2012-09-22 10:49 ` guanxuetao
2012-09-27 19:40 ` Thierry Reding
2012-09-18 8:23 ` Thierry Reding [this message]
2012-09-22 2:56 ` [PATCH v2 3/5] unicore32: pwm: Remove unnecessary indirection guanxuetao
2012-09-18 8:23 ` [PATCH v2 4/5] unicore32: pwm: Use managed resource allocations Thierry Reding
2012-09-22 2:57 ` guanxuetao
2012-09-18 8:23 ` [PATCH v2 5/5] pwm: Move PUV3 PWM driver to PWM framework Thierry Reding
2012-09-22 2:58 ` guanxuetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347956633-15667-4-git-send-email-thierry.reding@avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=qinrui@mprc.pku.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®