From: Jim Cromie <jim.cromie@gmail.com>
To: jbaron@redhat.com, linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 3/6] dyndbg: add more info to -E2BIG log warning
Date: Tue, 18 Sep 2012 17:36:44 -0600 [thread overview]
Message-ID: <1348011407-24108-4-git-send-email-jim.cromie@gmail.com> (raw)
In-Reply-To: <1348011407-24108-1-git-send-email-jim.cromie@gmail.com>
Tell user how big the attempted write was, in case its not obvious.
This helped identify a missing flush in my stress-test script.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
lib/dynamic_debug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 43ae319..85258a8 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -693,7 +693,8 @@ static ssize_t ddebug_proc_write(struct file *file, const char __user *ubuf,
if (len == 0)
return 0;
if (len > USER_BUF_PAGE - 1) {
- pr_warn("expected <%d bytes into control\n", USER_BUF_PAGE);
+ pr_warn("expected <%d bytes into control, you wrote %d\n",
+ USER_BUF_PAGE, (int) len);
return -E2BIG;
}
tmpbuf = kmalloc(len + 1, GFP_KERNEL);
--
1.7.11.4
next prev parent reply other threads:[~2012-09-18 23:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1348011407-24108-1-git-send-email-jim.cromie@gmail.com>
2012-09-18 23:36 ` [PATCH 1/6] dyndbg: fix usability bug by adding pr_errs for -EINVALs Jim Cromie
2012-09-18 23:36 ` [PATCH 2/6] dyndbg: spelling fix s/conrol/control/ Jim Cromie
2012-09-18 23:36 ` Jim Cromie [this message]
2012-09-24 19:00 ` [PATCH 3/6] dyndbg: add more info to -E2BIG log warning Jason Baron
2012-09-24 19:04 ` Geert Uytterhoeven
2012-09-24 21:15 ` Jim Cromie
2012-09-18 23:36 ` [PATCH 4/6] dyndbg: increase verbosity for proc-show, proc-next Jim Cromie
2012-09-18 23:36 ` [PATCH 5/6] dyndbg: in dynamic_emit_prefix, change inter-field separator Jim Cromie
2012-09-19 2:56 ` Joe Perches
2012-09-24 19:04 ` Jason Baron
2012-09-18 23:36 ` [PATCH 6/6] dyndbg: change varname verbose_bytes to bytes_used Jim Cromie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348011407-24108-4-git-send-email-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®