From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755088Ab2ISPLE (ORCPT ); Wed, 19 Sep 2012 11:11:04 -0400 Received: from webmail.solarflare.com ([12.187.104.25]:19569 "EHLO ocex02.SolarFlarecom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754790Ab2ISPK7 (ORCPT ); Wed, 19 Sep 2012 11:10:59 -0400 Message-ID: <1348067454.4836.56.camel@deadeye.wl.decadent.org.uk> Subject: Re: [PATCH v2 4/9] net/macb: remove macb_get_drvinfo() From: Ben Hutchings To: Nicolas Ferre CC: , , , , , , Date: Wed, 19 Sep 2012 16:10:54 +0100 In-Reply-To: <3fbd9b0eb1e255eccd14ad43044e146776baa963.1348055112.git.nicolas.ferre@atmel.com> References: <3fbd9b0eb1e255eccd14ad43044e146776baa963.1348055112.git.nicolas.ferre@atmel.com> Organization: Solarflare Communications Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [88.96.1.126] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2012-09-19 at 13:55 +0200, Nicolas Ferre wrote: > This function has little meaning so remove it altogether and > let ethtool core fill in the fields automatically. > > Signed-off-by: Nicolas Ferre Reviewed-by: Ben Hutchings > --- > drivers/net/ethernet/cadence/macb.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 2948553..31f945c 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -1217,20 +1217,9 @@ static int macb_set_settings(struct net_device *dev, struct ethtool_cmd *cmd) > return phy_ethtool_sset(phydev, cmd); > } > > -static void macb_get_drvinfo(struct net_device *dev, > - struct ethtool_drvinfo *info) > -{ > - struct macb *bp = netdev_priv(dev); > - > - strcpy(info->driver, bp->pdev->dev.driver->name); > - strcpy(info->version, "$Revision: 1.14 $"); > - strcpy(info->bus_info, dev_name(&bp->pdev->dev)); > -} > - > static const struct ethtool_ops macb_ethtool_ops = { > .get_settings = macb_get_settings, > .set_settings = macb_set_settings, > - .get_drvinfo = macb_get_drvinfo, > .get_link = ethtool_op_get_link, > }; > -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.