From: Adil Mujeeb <mujeeb.adil@gmail.com>
To: willy@meta-x.org
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, mujeeb.adil@gmail.com
Subject: [PATCH] Staging: panel: Fixed a macro coding style issue
Date: Thu, 20 Sep 2012 01:10:09 +0530 [thread overview]
Message-ID: <1348083609-7852-1-git-send-email-mujeeb.adil@gmail.com> (raw)
Removed do {} while (0) loop for a single statement macros
Signed-off-by: Adil Mujeeb <mujeeb.adil@gmail.com>
---
linux-3.6-rc6/drivers/staging/panel/panel.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/linux-3.6-rc6/drivers/staging/panel/panel.c b/linux-3.6-rc6/drivers/staging/panel/panel.c
index 39f9982..d9fec5b 100644
--- a/linux-3.6-rc6/drivers/staging/panel/panel.c
+++ b/linux-3.6-rc6/drivers/staging/panel/panel.c
@@ -137,8 +137,8 @@
#define r_ctr(x) (parport_read_control((x)->port))
#define r_dtr(x) (parport_read_data((x)->port))
#define r_str(x) (parport_read_status((x)->port))
-#define w_ctr(x, y) do { parport_write_control((x)->port, (y)); } while (0)
-#define w_dtr(x, y) do { parport_write_data((x)->port, (y)); } while (0)
+#define w_ctr(x, y) (parport_write_control((x)->port, (y)))
+#define w_dtr(x, y) (parport_write_data((x)->port, (y)))
/* this defines which bits are to be used and which ones to be ignored */
/* logical or of the output bits involved in the scan matrix */
--
1.7.7.3
next reply other threads:[~2012-09-19 19:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 19:40 Adil Mujeeb [this message]
2012-09-20 9:02 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2012-09-19 19:37 Adil Mujeeb
2012-09-19 19:44 ` Joe Perches
2012-09-19 20:39 ` Willy Tarreau
2012-09-20 3:49 ` Adil Mujeeb
2012-09-20 5:22 ` Willy Tarreau
2012-09-20 5:39 ` Adil Mujeeb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348083609-7852-1-git-send-email-mujeeb.adil@gmail.com \
--to=mujeeb.adil@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@meta-x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome