mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>,
	Stephane Eranian <eranian@google.com>,
	Namhyung Kim <namhyung.kim@lge.com>,
	Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
	Dong Hao <haodong@linux.vnet.ibm.com>
Subject: [PATCH 5/6] perf kvm: Use perf_session_env for reading cpuid
Date: Mon, 24 Sep 2012 17:15:02 +0900	[thread overview]
Message-ID: <1348474503-15070-6-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1348474503-15070-1-git-send-email-namhyung@kernel.org>

From: Namhyung Kim <namhyung.kim@lge.com>

We have processed and saved cpuid information to perf_session_env
so reuse it for get_cpu_isa().

Cc: David Ahern <dsahern@gmail.com>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Dong Hao <haodong@linux.vnet.ibm.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/builtin-kvm.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index 819af25a9a11..b76b3aa14ffd 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -664,16 +664,9 @@ static struct perf_tool eops = {
 
 static int get_cpu_isa(struct perf_session *session)
 {
-	char *cpuid;
+	char *cpuid = session->header.env.cpuid;
 	int isa;
 
-	cpuid = perf_header__read_feature(session, HEADER_CPUID);
-
-	if (!cpuid) {
-		pr_err("read HEADER_CPUID failed.\n");
-		return -ENOTSUP;
-	}
-
 	if (strstr(cpuid, "Intel"))
 		isa = 1;
 	else if (strstr(cpuid, "AMD"))
@@ -683,7 +676,6 @@ static int get_cpu_isa(struct perf_session *session)
 		isa = -ENOTSUP;
 	}
 
-	free(cpuid);
 	return isa;
 }
 
-- 
1.7.11.4


  parent reply	other threads:[~2012-09-24  8:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24  8:14 [PATCH 0/6] perf header: Save and reuse feature information in header (v5) Namhyung Kim
2012-09-24  8:14 ` [PATCH 1/6] perf header: Add struct perf_session_env Namhyung Kim
2012-09-27  5:29   ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-09-24  8:14 ` [PATCH 2/6] perf header: Add ->process callbacks to most of features Namhyung Kim
2012-09-27  5:30   ` [tip:perf/core] perf header: Add -> process " tip-bot for Namhyung Kim
2012-09-24  8:15 ` [PATCH 3/6] perf header: Use pre-processed session env when printing Namhyung Kim
2012-09-27  5:31   ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-09-24  8:15 ` [PATCH 4/6] perf header: Remove unused @feat arg from ->process callback Namhyung Kim
2012-09-27  5:32   ` [tip:perf/core] perf header: Remove unused @feat arg from -> process callback tip-bot for Namhyung Kim
2012-09-24  8:15 ` Namhyung Kim [this message]
2012-09-27  5:33   ` [tip:perf/core] perf kvm: Use perf_session_env for reading cpuid tip-bot for Namhyung Kim
2012-09-24  8:15 ` [PATCH 6/6] perf header: Remove perf_header__read_feature Namhyung Kim
2012-09-27  5:34   ` [tip:perf/core] " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348474503-15070-6-git-send-email-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=haodong@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    --cc=xiaoguangrong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®