From: Shubhrajyoti D <shubhrajyoti@ti.com>
To: <rtc-linux@googlegroups.com>
Cc: <linux-kernel@vger.kernel.org>, <julia.lawall@lip6.fr>,
<a.zummo@towertech.it>, Shubhrajyoti D <shubhrajyoti@ti.com>
Subject: [PATCHv2 4/7] rtc: Convert struct i2c_msg initialization to C99 format
Date: Mon, 24 Sep 2012 15:17:43 +0530 [thread overview]
Message-ID: <1348480066-3132-5-git-send-email-shubhrajyoti@ti.com> (raw)
In-Reply-To: <1348480066-3132-1-git-send-email-shubhrajyoti@ti.com>
Convert the struct i2c_msg initialization to C99 format. This makes
maintaining and editing the code simpler. Also helps once other fields
like transferred are added in future.
while at it also fix a checkpatch warn
WARNING: sizeof rs5c->buf should be sizeof(rs5c->buf)
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
drivers/rtc/rtc-rs5c372.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/rtc/rtc-rs5c372.c b/drivers/rtc/rtc-rs5c372.c
index fb4842c..76f565a 100644
--- a/drivers/rtc/rtc-rs5c372.c
+++ b/drivers/rtc/rtc-rs5c372.c
@@ -104,7 +104,12 @@ static int rs5c_get_regs(struct rs5c372 *rs5c)
{
struct i2c_client *client = rs5c->client;
struct i2c_msg msgs[] = {
- { client->addr, I2C_M_RD, sizeof rs5c->buf, rs5c->buf },
+ {
+ .addr = client->addr,
+ .flags = I2C_M_RD,
+ .len = sizeof(rs5c->buf),
+ .buf = rs5c->buf
+ },
};
/* This implements the third reading method from the datasheet, using
--
1.7.5.4
next prev parent reply other threads:[~2012-09-24 9:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 9:47 [PATCHv2 0/7] rtc: convert to c99 format Shubhrajyoti D
2012-09-24 9:47 ` [PATCHv2 1/7] rtc: Convert struct i2c_msg initialization to C99 format Shubhrajyoti D
2012-09-24 9:47 ` [PATCHv2 2/7] " Shubhrajyoti D
2012-09-24 9:47 ` [PATCHv2 3/7] " Shubhrajyoti D
2012-09-24 9:47 ` Shubhrajyoti D [this message]
2012-09-24 9:47 ` [PATCHv2 5/7] " Shubhrajyoti D
2012-09-24 9:47 ` [PATCHv2 6/7] " Shubhrajyoti D
2012-09-24 9:47 ` [PATCHv2 7/7] " Shubhrajyoti D
2012-09-25 10:33 [PATCHv2 0/7] rtc: convert to c99 format Shubhrajyoti D
2012-09-25 10:33 ` [PATCHv2 4/7] rtc: Convert struct i2c_msg initialization to C99 format Shubhrajyoti D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348480066-3132-5-git-send-email-shubhrajyoti@ti.com \
--to=shubhrajyoti@ti.com \
--cc=a.zummo@towertech.it \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®