From: Ian Campbell <Ian.Campbell@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "Oliver Chick (Intern)" <oliver.chick@citrix.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [Xen-devel] [PATCH v2] Persistent grant maps for xen blk drivers
Date: Mon, 24 Sep 2012 12:44:53 +0100 [thread overview]
Message-ID: <1348487093.3452.62.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <506061E6020000780009D4AB@nat28.tlf.novell.com>
On Mon, 2012-09-24 at 12:36 +0100, Jan Beulich wrote:
> >>> On 21.09.12 at 17:52, Oliver Chick <oliver.chick@citrix.com> wrote:
> > Changes since v1:
> >
> > * Maximum number of persistent grants per device now 64, rather than
> > 256, as this is the actual maxmimum request in a (1 page) ring.
>
> As said previously, I don't see why this needs to have a separate
> #define at all - it's simply __RING_SIZE(). No adding this would
> also imply that - apart from perhaps documenting the new xenstore
> nodes - io/blkif.h would need changing at all (which otherwise would
> require a hypervisor side patch to be submitted too).
Whether or not this definition is required in blkif.h we certainly want
a patch to the hypervisor tree to document this new protocol extension.
Ian.
next prev parent reply other threads:[~2012-09-24 11:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 15:52 Oliver Chick
2012-09-21 18:41 ` Konrad Rzeszutek Wilk
2012-09-21 18:56 ` Konrad Rzeszutek Wilk
2012-09-21 20:46 ` Konrad Rzeszutek Wilk
2012-09-24 14:38 ` Andres Lagar-Cavilla
2012-09-24 15:06 ` Konrad Rzeszutek Wilk
2012-09-24 15:21 ` Andres Lagar-Cavilla
2012-09-27 15:49 ` Oliver Chick
2012-09-24 11:36 ` [Xen-devel] " Jan Beulich
2012-09-24 11:44 ` Ian Campbell [this message]
2012-10-09 16:39 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348487093.3452.62.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.chick@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®