From: Feng Tang <feng.tang@intel.com>
To: acme@redhat.com
Cc: mingo@elte.hu, a.p.zijlstra@chello.nl, andi@firstfloor.org,
namhyung@kernel.org, dsahern@gmail.com,
linux-kernel@vger.kernel.org, Feng Tang <feng.tang@intel.com>
Subject: [PATCH v4 8/8] perf report: Enable the runtime switching of perf data file
Date: Fri, 28 Sep 2012 16:30:40 +0800 [thread overview]
Message-ID: <1348821040-9724-9-git-send-email-feng.tang@intel.com> (raw)
In-Reply-To: <1348821040-9724-1-git-send-email-feng.tang@intel.com>
This is for tui browser only. This patch will check the returned
key of tui hists browser, if it's K_SWITH_INPUT_DATA, then recreate
a session for the new selected data file.
Signed-off-by: Feng Tang <feng.tang@intel.com>
---
tools/perf/builtin-report.c | 18 ++++++++++++++++--
1 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index e4b2246..e8d92ed 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -426,8 +426,14 @@ static int __cmd_report(struct perf_report *rep)
if (use_browser > 0) {
if (use_browser == 1) {
- perf_evlist__tui_browse_hists(session->evlist, help,
- NULL, NULL, 0);
+ ret = perf_evlist__tui_browse_hists(session->evlist,
+ help, NULL, NULL, 0);
+ /*
+ * Usually "ret" is the last pressed key, and we only
+ * care if the key notifies us to switch data file.
+ */
+ if (ret != K_SWITCH_INPUT_DATA)
+ ret = 0;
} else if (use_browser == 2) {
perf_evlist__gtk_browse_hists(session->evlist, help,
NULL, NULL, 0);
@@ -661,6 +667,8 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
else
input_name = "perf.data";
}
+
+repeat:
session = perf_session__new(input_name, O_RDONLY,
report.force, false, &report.tool);
if (session == NULL)
@@ -761,6 +769,12 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
}
ret = __cmd_report(&report);
+ if (ret == K_SWITCH_INPUT_DATA) {
+ perf_session__delete(session);
+ goto repeat;
+ } else
+ ret = 0;
+
error:
perf_session__delete(session);
return ret;
--
1.7.1
prev parent reply other threads:[~2012-09-28 8:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 8:30 [PATCH v4 0/8] perf tools: Add script browser and runtime data file switch Feng Tang
2012-09-28 8:30 ` [PATCH v4 1/8] perf tool: Add a global variable "const char *input_name" Feng Tang
2012-09-28 8:30 ` [PATCH v4 2/8] perf script: Add more filter to find_scripts() Feng Tang
2012-09-28 8:30 ` [PATCH v4 3/8] perf ui/browser: Add a browser for perf script Feng Tang
2012-09-28 8:30 ` [PATCH v4 4/8] perf ui/browser: Integrate script browser into annotation browser Feng Tang
2012-09-28 8:30 ` [PATCH v4 5/8] perf ui/browser: Integrate script browser into main hists browser Feng Tang
2012-09-28 8:30 ` [PATCH v4 6/8] perf header: Add is_perf_magic() func Feng Tang
2012-09-28 8:30 ` [PATCH v4 7/8] perf hists browser: Add option for runtime switching perf data file Feng Tang
2012-09-28 8:30 ` Feng Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348821040-9724-9-git-send-email-feng.tang@intel.com \
--to=feng.tang@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®