mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Arnaldo Carvalho de Melo <acme@infradead.org>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] tools lib traceevent: Fix missed freeing of subargs in free_arg() in filter
Date: Mon, 01 Oct 2012 09:42:25 -0400	[thread overview]
Message-ID: <1349098945.22822.113.camel@gandalf.local.home> (raw)
In-Reply-To: <1349097395.1613.4.camel@leonhard>

On Mon, 2012-10-01 at 22:16 +0900, Namhyung Kim wrote:

> Although they have same layout, wouldn't it be better using their own
> fields?
> 
> 	case FILTER_ARG_NUM:
> 		free_arg(arg->num.left);
> 		free_arg(arg->num.right);
> 		break;
> 
> 	case FILTER_ARG_EXP:
> 		free_arg(arg->exp.left);
> 		free_arg(arg->exp.right);
> 		break;

Yeah, I got lazy. This is probably better. I'll resend.

Thanks,

-- Steve



      reply	other threads:[~2012-10-01 13:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-28 23:21 Steven Rostedt
2012-10-01 13:16 ` Namhyung Kim
2012-10-01 13:42   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349098945.22822.113.camel@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=acme@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®