From: Ian Munsie <imunsie@au1.ibm.com>
To: Ben Guthro <ben@guthro.net>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Namhyung Kim <namhyung.kim@lge.com>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: linux-next: build failure in dwarf-regs.c
Date: Tue, 02 Oct 2012 14:24:59 +1000 [thread overview]
Message-ID: <1349148496-sup-4820@delenn.ozlabs.ibm.com> (raw)
In-Reply-To: <CAOvdn6WPUDqYPpHZip7dxVVXJXT0-zJOUCpgDGb=o+zqq98F0Q@mail.gmail.com>
Hey Ben,
Adding some people to CC...
Excerpts from Ben Guthro's message of 2012-10-02 11:02:59 +1000:
> I pulled the latest bits up to 797b9e5ae93270ec27a1f1ed48cd697d01b2269f -
> but am seeing the following build failure with gcc 4.6.3
Building that SHA works for me (on x86, haven't tried PPC yet)...
> CC arch/x86/util/dwarf-regs.o
Is this correct? i.e. Are you building perf for x86?
What commandline are you using to build?
Any exported environment variables that may be relevant?
What dev libraries does perf warn is missing (Is libdw-dev among them)?
> arch/x86/util/dwarf-regs.c:72:13: error: no previous prototype for
> 'get_arch_regstr' [-Werror=missing-prototypes]
Hmmm... util/include/dwarf-regs.h not included? DWARF_SUPPORT undefined
but still building that file for some reason?
Can't see any obvious way that could happen... You didn't happen to see
an warning along the lines of 'DWARF register mappings not defined for
x86' did you?
> `/data/home/bguthro/dev/orc-newdev.git/linux/build/tools/tools/perf'
I hope the two 'tools' here is just an O= artefact?
> git blame shows that line coming in from the following changeset - though
> April is a long time ago in kernel time
Especially when it's April from two years ago...
> - so this must have come in with some other merge in this 3.7 window
Seems likely, especially as (excerpt from git diff --stat v3.6 797b9e5
-- tools/perf):
tools/perf/arch/x86/Makefile | 3 +
tools/perf/arch/x86/include/perf_regs.h | 80 +++
tools/perf/Makefile | 173 ++++--
I see a few changes in there that may have caused this... Since I can't
reproduce this myself I can't narrow it down, so I'm adding David Ahern,
Namhyung Kim & Jiri Olsa to CC who have touched lines that look like the
might be relevant.
Ben: You should be able to narrow down the cause of the breakage a bit
more with git bisect start 797b9e5 v3.6 -- tools/perf/Makefile
Cheers,
-Ian
next parent reply other threads:[~2012-10-02 4:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAOvdn6WPUDqYPpHZip7dxVVXJXT0-zJOUCpgDGb=o+zqq98F0Q@mail.gmail.com>
2012-10-02 4:24 ` Ian Munsie [this message]
2012-10-02 11:39 ` Ben Guthro
2012-10-02 13:10 ` [PATCH] perf tool: Fix build for NO_DWARF=1 case Jiri Olsa
2012-10-02 21:45 ` Arnaldo Carvalho de Melo
2012-10-03 10:29 ` Jiri Olsa
2012-10-03 13:29 ` Namhyung Kim
2012-10-02 1:10 linux-next: build failure in dwarf-regs.c Ben Guthro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349148496-sup-4820@delenn.ozlabs.ibm.com \
--to=imunsie@au1.ibm.com \
--cc=ben@guthro.net \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung.kim@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®