From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>
Subject: [PATCH 3/5] perf trace: Explicitly enable system-wide mode if no option is given
Date: Fri, 5 Oct 2012 14:02:14 +0900 [thread overview]
Message-ID: <1349413336-26936-3-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1349413336-26936-1-git-send-email-namhyung@kernel.org>
From: Namhyung Kim <namhyung.kim@lge.com>
When no target cpu/user/task option is given, perf trace will do its
job system wide for all online cpus. Make it explicit to reduce
possible confusion when reading code.
No functional changes intended.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/builtin-trace.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 7bb7e757c745..231b60690ce9 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -344,6 +344,9 @@ int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused)
return err;
}
+ if (perf_target__none(&trace.opts.target))
+ trace.opts.target.system_wide = true;
+
setup_pager();
return trace__run(&trace);
--
1.7.11.4
next prev parent reply other threads:[~2012-10-05 6:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 5:02 [PATCH 1/5] perf trace: Setup pager before running Namhyung Kim
2012-10-05 5:02 ` [PATCH 2/5] perf trace: Validate target task/user/cpu argument Namhyung Kim
2012-10-09 17:19 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-10-05 5:02 ` Namhyung Kim [this message]
2012-10-09 17:20 ` [tip:perf/core] perf trace: Explicitly enable system-wide mode if no option is given tip-bot for Namhyung Kim
2012-10-05 5:02 ` [PATCH 4/5] perf trace: Add -a switch for --all-cpus option Namhyung Kim
2012-10-05 5:02 ` [PATCH 5/5] perf trace: Add support for tracing workload given by command line Namhyung Kim
2012-10-09 17:21 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-10-05 15:47 ` [PATCH 1/5] perf trace: Setup pager before running Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349413336-26936-3-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®