From: Ben Hutchings <bhutchings@solarflare.com>
To: <monstr@monstr.eu>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Anirudha Sarangi <anirudh@xilinx.com>,
John Linn <John.Linn@xilinx.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 11/11] net: xilinx: Show csum in bootlog
Date: Fri, 5 Oct 2012 14:51:02 +0100 [thread overview]
Message-ID: <1349445062.16173.48.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <506EA9C4.2000609@monstr.eu>
On Fri, 2012-10-05 at 11:35 +0200, Michal Simek wrote:
> On 10/04/2012 09:15 PM, Ben Hutchings wrote:
> > On Thu, 2012-10-04 at 20:14 +0200, Michal Simek wrote:
> >> Just show current setting in bootlog.
> > [...]
> >> --- a/drivers/net/ethernet/xilinx/ll_temac_main.c
> >> +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
> >> @@ -1052,12 +1052,14 @@ static int __devinit temac_of_probe(struct platform_device *op)
> >> /* Setup checksum offload, but default to off if not specified */
> >> lp->temac_features = 0;
> >> p = (__be32 *)of_get_property(op->dev.of_node, "xlnx,txcsum", NULL);
> >> + dev_info(&op->dev, "TX_CSUM %d\n", be32_to_cpup(p));
> >> if (p && be32_to_cpu(*p)) {
> >> lp->temac_features |= TEMAC_FEATURE_TX_CSUM;
> >> /* Can checksum TCP/UDP over IPv4. */
> >> ndev->features |= NETIF_F_IP_CSUM;
> >> }
> >> p = (__be32 *)of_get_property(op->dev.of_node, "xlnx,rxcsum", NULL);
> >> + dev_info(&op->dev, "RX_CSUM %d\n", be32_to_cpup(p));
> > [...]
> >
> > Is there any particular reason you think this needs to be logged by
> > default, rather than letting users run ethtool -k? I suggest using
> > dev_dbg() instead.
>
> Ok. I have looked at it and there are missing some bits in ndev->features.
>
> Can you please check that my setting is correct?
>
> It is SG DMA ip/driver.
> ndev->features = NETIF_F_FRAGLIST | NETIF_F_SG
NETIF_F_SG only; NETIF_F_FRAGLIST means you can handle skbs chained
through the frag_list pointer.
> With two options for csum on RX/TX. They can be selected independently.
> tx Partial csum over IPv4. -> NETIF_F_IP_CSUM
> tx Full csum. -> NETIF_F_HW_CSUM
NETIF_F_IP_CSUM means you have hardware checksum generation for TCP/IPv4
and UDP/IPv4 only (XAE_FEATURE_FULL_TX_CSUM).
NETIF_F_HW_CSUM means you have generic TCP-style checksum generation
using the csum_start and csum_offset fields of the skb
(XAE_FEATURE_PARTIAL_TX_CSUM). By the way, you're actually testing
XAE_FEATURE_PARTIAL_RX_CSUM in axienet_start_xmit()...
> rx Full csum -> NETIF_F_RXCSUM
>
> Is there any option to support partial csum?
There is no need to differentiate these in the device features. For TX
the stack needs to know whether to use a software fallback before
passing the skb to you, but on RX it looks at the ip_summed field of
each skb you pass up.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2012-10-05 13:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 18:14 [PATCH 01/11] net: axienet: Remove NETIF_F_SG dropping for no checksum feature Michal Simek
2012-10-04 18:14 ` [PATCH 02/11] net: axienet: Add ioctl support Michal Simek
2012-10-04 19:17 ` Ben Hutchings
2012-10-05 5:54 ` Michal Simek
2012-10-04 18:14 ` [PATCH 03/11] net: axienet: Do not use NO_IRQ Michal Simek
2012-10-04 18:14 ` [PATCH 04/11] net: axienet: Additional MDIO clock functionality Michal Simek
2012-10-04 18:14 ` [PATCH 05/11] net: axienet: Enable VLAN support by default Michal Simek
2012-10-04 18:14 ` [PATCH 06/11] net: ll_temac: Fix mdio initialization Michal Simek
2012-10-04 18:14 ` [PATCH 07/11] net: ll_temac: Fix DMA map size bug Michal Simek
2012-10-04 18:14 ` [PATCH 08/11] net: ll_temac: Do not use fixed mtu size Michal Simek
2012-10-04 19:22 ` Ben Hutchings
2012-10-05 5:58 ` Michal Simek
2012-10-04 18:14 ` [PATCH 09/11] net: ll_temac: Move frag loading to frag loop Michal Simek
2012-10-04 18:14 ` [PATCH 10/11] net: ll_temac: Simplify xmit Michal Simek
2012-10-04 18:14 ` [PATCH 11/11] net: xilinx: Show csum in bootlog Michal Simek
2012-10-04 19:15 ` Ben Hutchings
2012-10-05 5:48 ` Michal Simek
2012-10-05 13:36 ` Ben Hutchings
2012-10-05 9:35 ` Michal Simek
2012-10-05 13:51 ` Ben Hutchings [this message]
2012-10-09 9:08 ` Michal Simek
2012-10-09 16:56 ` Ben Hutchings
2012-10-10 16:06 ` Michal Simek
2012-10-10 16:14 ` Ben Hutchings
2012-10-04 18:26 ` [PATCH 01/11] net: axienet: Remove NETIF_F_SG dropping for no checksum feature David Miller
2012-10-05 5:22 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349445062.16173.48.camel@deadeye.wl.decadent.org.uk \
--to=bhutchings@solarflare.com \
--cc=John.Linn@xilinx.com \
--cc=anirudh@xilinx.com \
--cc=davem@davemloft.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®