From: Joe Perches <joe@perches.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: "Theodore Ts'o" <tytso@mit.edu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] random: make it possible to enable debugging without rebuild
Date: Mon, 08 Oct 2012 12:45:50 -0700 [thread overview]
Message-ID: <1349725550.15802.21.camel@joe-AO722> (raw)
In-Reply-To: <alpine.LNX.2.00.1210081637170.28357@pobox.suse.cz>
On Mon, 2012-10-08 at 16:39 +0200, Jiri Kosina wrote:
> The module parameter that turns debugging mode (which basically means
> printing a few extra lines during runtime) is in '#if 0' block. Forcing
> everyone who would like to see how entropy is behaving on his system seems
> to be a little bit too harsh.
> If we were concerned about speed, we could potentially turn 'debug' into
> a static key, but I don't think it's necessary.
>
> Drop the '#if 0' block to allow using the 'debug' parameter without rebuilding.
I'd also convert the printk(KERN_DEBUG to pr_debug
to avoid penalizing non-debug builds altogether.
next prev parent reply other threads:[~2012-10-08 19:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 14:39 Jiri Kosina
2012-10-08 14:40 ` [PATCH 2/2] random: fix debug format strings Jiri Kosina
2012-10-15 21:43 ` [RESEND] " Jiri Kosina
2012-10-16 3:43 ` Theodore Ts'o
2012-10-08 19:45 ` Joe Perches [this message]
2012-10-15 21:42 ` [RESEND] [PATCH 1/2] random: make it possible to enable debugging without rebuild Jiri Kosina
2012-10-16 3:43 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349725550.15802.21.camel@joe-AO722 \
--to=joe@perches.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®