mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: linux-kernel@vger.kernel.org, axboe@kernel.dk
Cc: vgoyal@redhat.com, jmoyer@redhat.com, tj@kernel.org
Subject: [PATCH 1/8] cfq-iosched: Make cfq_scale_slice() usable for both queues and groups
Date: Mon,  8 Oct 2012 17:44:53 -0400	[thread overview]
Message-ID: <1349732700-2694-2-git-send-email-vgoyal@redhat.com> (raw)
In-Reply-To: <1349732700-2694-1-git-send-email-vgoyal@redhat.com>

Make cfq_scale_slice() usable both for queues and groups by taking in
weight as a parameter.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
 block/cfq-iosched.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 2f2b215..c0b492e 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -851,12 +851,12 @@ cfq_prio_to_slice(struct cfq_data *cfqd, struct cfq_queue *cfqq)
 	return cfq_prio_slice(cfqd, cfq_cfqq_sync(cfqq), cfqq->ioprio);
 }
 
-static inline u64 cfq_scale_slice(unsigned long delta, struct cfq_group *cfqg)
+static inline u64 cfq_scale_slice(unsigned long delta, unsigned int weight)
 {
 	u64 d = delta << CFQ_SERVICE_SHIFT;
 
 	d = d * CFQ_WEIGHT_DEFAULT;
-	do_div(d, cfqg->weight);
+	do_div(d, weight);
 	return d;
 }
 
@@ -1299,7 +1299,7 @@ static void cfq_group_served(struct cfq_data *cfqd, struct cfq_group *cfqg,
 
 	/* Can't update vdisktime while group is on service tree */
 	cfq_group_service_tree_del(st, cfqg);
-	cfqg->vdisktime += cfq_scale_slice(charge, cfqg);
+	cfqg->vdisktime += cfq_scale_slice(charge, cfqg->weight);
 	/* If a new weight was requested, update now, off tree */
 	cfq_group_service_tree_add(st, cfqg);
 
-- 
1.7.7.6


  reply	other threads:[~2012-10-08 21:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-08 21:44 [PATCH 0/8] cfq-iosched: Use vdisktime based scheduling logic for cfq queues [V2] Vivek Goyal
2012-10-08 21:44 ` Vivek Goyal [this message]
2012-10-08 21:44 ` [PATCH 2/8] cfq-iosched: make new_cfqq variable bool Vivek Goyal
2012-10-08 21:44 ` [PATCH 3/8] cfq-iosced: Do the round robin selection of workload type Vivek Goyal
2012-10-08 21:44 ` [PATCH 4/8] cfq-iosched: Put new queue at the end of servie tree always Vivek Goyal
2012-10-08 21:44 ` [PATCH 5/8] cfq-iosched: Remove residual slice logic Vivek Goyal
2012-10-08 21:44 ` [PATCH 6/8] cfq-iosched: put cooperating queue at the front of service tree Vivek Goyal
2012-10-08 21:44 ` [PATCH 7/8] cfq-iosched: Use same scheduling algorithm for groups and queues Vivek Goyal
2012-10-08 21:45 ` [PATCH 8/8] cfq-iosched: Wait for queue to get busy even if this is not last queue in group Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349732700-2694-2-git-send-email-vgoyal@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®