From: Laxman Dewangan <ldewangan@nvidia.com>
To: <broonie@opensource.wolfsonmicro.com>,
<gregkh@linuxfoundation.org>, <sameo@linux.intel.com>
Cc: <swarren@nvidia.com>, <linux-kernel@vger.kernel.org>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: [PATCH 3/5] mfd: tps65910: Initialize mfd devices after all initialization done
Date: Tue, 9 Oct 2012 16:58:34 +0530 [thread overview]
Message-ID: <1349782116-9757-4-git-send-email-ldewangan@nvidia.com> (raw)
In-Reply-To: <1349782116-9757-1-git-send-email-ldewangan@nvidia.com>
Add sub devices of tps65910 after all initialization like interrupt,
clock etc. is done. This will make sure that require data gets
initialized properly before sub devices probe's get called.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
drivers/mfd/tps65910.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index 11adedb..f7f9d3a 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -495,18 +495,10 @@ static __devinit int tps65910_i2c_probe(struct i2c_client *i2c,
return ret;
}
- ret = mfd_add_devices(tps65910->dev, -1,
- tps65910s, ARRAY_SIZE(tps65910s),
- NULL, 0, NULL);
- if (ret < 0) {
- dev_err(&i2c->dev, "mfd_add_devices failed: %d\n", ret);
- return ret;
- }
-
init_data->irq = pmic_plat_data->irq;
init_data->irq_base = pmic_plat_data->irq_base;
-
tps65910_irq_init(tps65910, init_data->irq, init_data);
+
tps65910_ck32k_init(tps65910, pmic_plat_data);
tps65910_sleepinit(tps65910, pmic_plat_data);
@@ -515,6 +507,14 @@ static __devinit int tps65910_i2c_probe(struct i2c_client *i2c,
pm_power_off = tps65910_power_off;
}
+ ret = mfd_add_devices(tps65910->dev, -1,
+ tps65910s, ARRAY_SIZE(tps65910s),
+ NULL, 0, NULL);
+ if (ret < 0) {
+ dev_err(&i2c->dev, "mfd_add_devices failed: %d\n", ret);
+ return ret;
+ }
+
return ret;
}
--
1.7.1.1
next prev parent reply other threads:[~2012-10-09 12:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 11:28 [PATCH 0/5] mfd: tps65910: use regmap irq framework for interrupt Laxman Dewangan
2012-10-09 11:28 ` [PATCH 1/5] mfd: tps65910: use regmap irq framework for interrupt support Laxman Dewangan
2012-10-10 3:07 ` Mark Brown
2012-10-09 11:28 ` [PATCH 2/5] mfd: tps65910: move interrupt implementation code to mfd file Laxman Dewangan
2012-10-10 3:08 ` Mark Brown
2012-10-09 11:28 ` Laxman Dewangan [this message]
2012-10-10 3:09 ` [PATCH 3/5] mfd: tps65910: Initialize mfd devices after all initialization done Mark Brown
2012-10-09 11:28 ` [PATCH 4/5] regmap: add API to get irq_domain from regmap irq Laxman Dewangan
2012-10-10 2:08 ` Mark Brown
2012-10-09 11:28 ` [PATCH 5/5] mfd: tps65910: pass irq_domain when adding mfd sub devices Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349782116-9757-4-git-send-email-ldewangan@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®