From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Akhil R <akhilrajeev@nvidia.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: drivers/crypto/tegra/tegra-se-aes.c:1596 tegra_cmac_do_one_req() error: uninitialized symbol 'ret'.
Date: Mon, 9 Dec 2024 09:24:49 +0300 [thread overview]
Message-ID: <134e89a8-49a0-4675-8e07-4f257828f51d@stanley.mountain> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b5f217084ab3ddd4bdd03cd437f8e3b7e2d1f5b6
commit: 0880bb3b00c855fc244b7177ffdaafef4d0aa1e0 crypto: tegra - Add Tegra Security Engine driver
date: 8 months ago
config: nios2-randconfig-r073-20241206 (https://download.01.org/0day-ci/archive/20241207/202412071747.flPux4oB-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202412071747.flPux4oB-lkp@intel.com/
smatch warnings:
drivers/crypto/tegra/tegra-se-aes.c:1596 tegra_cmac_do_one_req() error: uninitialized symbol 'ret'.
vim +/ret +1596 drivers/crypto/tegra/tegra-se-aes.c
0880bb3b00c855f Akhil R 2024-04-03 1577 static int tegra_cmac_do_one_req(struct crypto_engine *engine, void *areq)
0880bb3b00c855f Akhil R 2024-04-03 1578 {
0880bb3b00c855f Akhil R 2024-04-03 1579 struct ahash_request *req = ahash_request_cast(areq);
0880bb3b00c855f Akhil R 2024-04-03 1580 struct tegra_cmac_reqctx *rctx = ahash_request_ctx(req);
0880bb3b00c855f Akhil R 2024-04-03 1581 struct crypto_ahash *tfm = crypto_ahash_reqtfm(req);
0880bb3b00c855f Akhil R 2024-04-03 1582 struct tegra_cmac_ctx *ctx = crypto_ahash_ctx(tfm);
0880bb3b00c855f Akhil R 2024-04-03 1583 struct tegra_se *se = ctx->se;
0880bb3b00c855f Akhil R 2024-04-03 1584 int ret;
0880bb3b00c855f Akhil R 2024-04-03 1585
0880bb3b00c855f Akhil R 2024-04-03 1586 if (rctx->task & SHA_UPDATE) {
0880bb3b00c855f Akhil R 2024-04-03 1587 ret = tegra_cmac_do_update(req);
0880bb3b00c855f Akhil R 2024-04-03 1588 rctx->task &= ~SHA_UPDATE;
0880bb3b00c855f Akhil R 2024-04-03 1589 }
0880bb3b00c855f Akhil R 2024-04-03 1590
0880bb3b00c855f Akhil R 2024-04-03 1591 if (rctx->task & SHA_FINAL) {
0880bb3b00c855f Akhil R 2024-04-03 1592 ret = tegra_cmac_do_final(req);
0880bb3b00c855f Akhil R 2024-04-03 1593 rctx->task &= ~SHA_FINAL;
0880bb3b00c855f Akhil R 2024-04-03 1594 }
Is it possible for both SHA_UPDATE and SHA_FINAL to be clear?
0880bb3b00c855f Akhil R 2024-04-03 1595
0880bb3b00c855f Akhil R 2024-04-03 @1596 crypto_finalize_hash_request(se->engine, req, ret);
^^^
If so then this is uninitialized.
0880bb3b00c855f Akhil R 2024-04-03 1597
0880bb3b00c855f Akhil R 2024-04-03 1598 return 0;
0880bb3b00c855f Akhil R 2024-04-03 1599 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-12-09 6:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 6:24 Dan Carpenter [this message]
2024-12-22 4:18 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=134e89a8-49a0-4675-8e07-4f257828f51d@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=akhilrajeev@nvidia.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®