From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE3D132B9A6 for ; Wed, 21 Jan 2026 06:59:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768978795; cv=none; b=Z1m999OWhK8UTWEOoWNhDYOXJzQkGR1UNzRninnYYcz29DKDbDWrK9xOKkwU3EPm3y0I/A5nBS0+DDr7mrwy6EZNw3svAUhbSAuznUQPc1cYEaXk7YHAboqgmhlJJ5BHeirM+0OjfOR5//+vj4wGINemJwN6jrbUNtKfxZIQh/k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768978795; c=relaxed/simple; bh=+VmfiF6q1AJoQSkRpXQ/F/cBZuggrkXNhPRZ0UNCgzY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hpJxeFfrPTsZ8rAbJUUgcAlcAOCvPIkcdqszrMaLEyyUuxNB5RqksT9DkddNFxmD7nwQalSvJCrlbT/BCFsLpqujJeIUSPeUuze/bnz+sepU+gd21lsm+ZSdDQBV76Cq9ble/hsgmGALZnm+z52VQWoJnBWKuQMnxpIHMMnGHrI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bwTdlkkO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eBvAfi/9; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bwTdlkkO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eBvAfi/9" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60L6XK992938419 for ; Wed, 21 Jan 2026 06:59:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 44gRnAKBKMmfl1NDqW9q0LpAxwiIZ6f2VPZlXasmGE0=; b=bwTdlkkOHsM+d4Fd w0k21PcKq29F7JaBmyFIwIX4CDhqTbvp8MpNrwN2h8RgLSreCCoAyKflk7HaiCbg YegpcDAe7UpFr9cECH3cPMrQdwKgHO7IEx/PWO0egiJL647v+jKFx9TVswDMwlrO ZfXnARzMKGmexT+gbx+ZE4kA2AYIwlNoKYHhBGJ0OLEEJ9lWdaV/fjK0wtYr0Rvh nXnzzMnNG+uJh7wH4reqhVY2VkbmroAxkl9enj7Ptt7U7NO1OMxlM9ZtgU3PQg3n LBU9Sh/edR0Q/TwBc6HvVncqzf7sHLD5PkFktveofsluq/B3ObE1JK11kJqxKsE1 aCne3w== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4btsmu82ca-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 21 Jan 2026 06:59:52 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-2b6e47d2fdfso2967451eec.1 for ; Tue, 20 Jan 2026 22:59:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768978792; x=1769583592; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=44gRnAKBKMmfl1NDqW9q0LpAxwiIZ6f2VPZlXasmGE0=; b=eBvAfi/91cU9f7JF9XlMDgovVDWz9xjK383lNilsThsaXUQcT0JgyeW8UzIigEoUNM 74gptPLid9EYZKKi7QDS0t/dMMXjp7GweQmrEl2WuC5VMTPW1N3lLU0HYa5EGsjEWTkX CmfSGRNmeLQ3brJ1wEfRkqd/JbANT8cOGtXonnRs+f2nnSJpClkaiSazqQDxPBOLq33A vPdStCIlICZIzRm2rvl82xIeDcQUdPiX3ujcQnoJy5z3IG9Ni2el0lOyOWQRcy6ROQeE M5rnpXCM8qBVpjev7FTA18ERpDeK9P7reXRc0uIFkC460Psx/aAkiA1Ncgkx5wR2YadN Nj5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768978792; x=1769583592; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=44gRnAKBKMmfl1NDqW9q0LpAxwiIZ6f2VPZlXasmGE0=; b=AyM/7dkPDmhM4yGNFHkrpJff3F/HJJpm5ptoTtcHPPunGVk4xNmoDlyL3YdjsoXB9U eOZz7d8OM2rOSDDXn0e1v9NpooRDG5YYj2/oD0Whx2dSMFZuogAoRaQ50qiH7YgQ0ifH V+cEjBBzPW+FZKfCNPYNWrrww8tey/Tjv3FoSQOw98eGxT2eRb+V0H1KgWyj/03bcukv Jpe5rF30Bi7+oqvvTro3DrWwxWJpNBWATV0SHNn1KH8IA781cdNWR/AIhPssTTdQ+QdG Z6plko9/b5WAJ7JdBLN0UAAjAkMlEON6xBrEIP7QFc7SjyEZztifGEPFb995x98+6BbQ lWuw== X-Forwarded-Encrypted: i=1; AJvYcCWeGwulHKQSAHCfKizIPAit5IJqs1dpJ7yyK9CBaVQ3lJPsESN4ojP3/dJuH2fw7iAeq7RrQ0aBK6nL/sE=@vger.kernel.org X-Gm-Message-State: AOJu0YxA/0YLTOcZviKk595gk/q5EOFIN4cmLYMfCvqaukNAiKw7i2LB YpP96Yj/BJRAycBRmCLH8KEhp47eKw7SFsFrMOzvOHImGJWk/saakV3aFZEWiBGJWSWcqYjCUVV Be6c5MJjT3I+3KmUyGB3jK1SfHLHEUKiWxOC9kXL/q40counyjoZuxoJqrrmyO9gAF6k= X-Gm-Gg: AZuq6aLVsa8bbnqOH2qOIZ/UkYy43+4auvUgfrKDuG5lO6cBrxh38sknPbVfD+POjpm ar5oKYP6uTbOT5j+PLhTLf13r4e+q8SXKHV7x5sGrypZ+cOj5vNyGx9w4QqNFiaWSjyGeLmDy0S Vf0zzfbj03Cr5I5oIOw9TBC/BNeJjGf1f9LVZsiJ4rvVTrbZYAMfDWkTQm91N3HMzaOwuOagOW2 XNT2wcWiEoCjJc0SYZtbXgwVUVdbqqOukGta8OTEbIPZjlXCjZbaGn3eTWGFfvg81QJFW9S+LlW jTDD0BLpgB/XM35st8bgN0vJzQ1+a+fSHXy/mnoVNKIF84DenzS/PDMrRhRtGbJdi8lEgNVUzeJ ZyCb/DZMWsBKwK+bWa1RvmMDc1p9xe2sr3mM6c6AJgLqn553jtTyqnS7HdaPxFcTm X-Received: by 2002:a05:7022:6b91:b0:11b:9386:a37b with SMTP id a92af1059eb24-1244a78d435mr11430958c88.42.1768978791532; Tue, 20 Jan 2026 22:59:51 -0800 (PST) X-Received: by 2002:a05:7022:6b91:b0:11b:9386:a37b with SMTP id a92af1059eb24-1244a78d435mr11430951c88.42.1768978790893; Tue, 20 Jan 2026 22:59:50 -0800 (PST) Received: from [10.110.110.132] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6fb72e477sm5575769eec.29.2026.01.20.22.59.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jan 2026 22:59:50 -0800 (PST) Message-ID: <135000f3-b444-44e3-bbce-e5e274e6180a@oss.qualcomm.com> Date: Wed, 21 Jan 2026 14:59:45 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260120070650.3192679-1-wei.zhang@oss.qualcomm.com> Content-Language: en-US From: "Wei Zhang (Stone)" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=OaiVzxTY c=1 sm=1 tr=0 ts=69707968 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=COk6AnOGAAAA:8 a=uRIq5cPlbIFpHDivVdoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: A59ZqbUVV3f985jgDQWR-B4w15bkMPV0 X-Proofpoint-ORIG-GUID: A59ZqbUVV3f985jgDQWR-B4w15bkMPV0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIxMDA1NiBTYWx0ZWRfX5F3B5y1FjcWG DWfgEXHC8r2wPdpQbGmLvwIgY3MyGMf43k7iQqeaHOwvh3YmxGu8S9MFXgaaCN/HL1KeW4qWi/w ok9H6PKpPqCYlTtTEM4c71W9bIbPKLIRRzmjkH+HID7OXZbu8wBMfjiHugJnV1MgVup3xiRULbK 1u96LgRIUSwwj73T3tsSPPGiIwHiFLCUtYGf/p0bwPm0n+OwjqHE1SWFwoQAOm2qmZH3lCjXkh/ sPrNNOPDq2XA4cEzpsGBXnNBREacH9+YPLWRoiFq3+P1l6oF9ryWuKarOqlNcvzG0eAgGhPry1U eVq8stS4Nf9bTL+bgVZLISNWN88SdkrgEgqtCOPOU0VhoC5/XHZJJXeXDH3q/LanUjgs2s4MsBu Xi1iDo9nC0+GMvlUUA8J05oP63093XccTlIQYBBe6G4l46UadFlwewcysjtoG2ApNMfdxaid+0J 1Kdv/ecvER0PpqrRLtw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-21_01,2026-01-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 impostorscore=0 suspectscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601210056 On 1/20/2026 3:44 PM, Dmitry Baryshkov wrote: > On Mon, Jan 19, 2026 at 11:06:49PM -0800, Wei Zhang wrote: >> Enable WLAN on qcs8300-ride by adding a node for the PMU module >> of the WCN6855 and assigning its LDO power outputs to the existing >> WiFi module. >> >> On the qcs8300-ride platform, the corresponding firmware and BDF >> are QCA6698AQ instead of WCN6855, which have been added in the >> 20250211 release. >> >> Signed-off-by: Wei Zhang >> --- >> This patch depends on: >> - PCIe >> https://lore.kernel.org/all/20251128104928.4070050-1-ziyue.zhang@oss.qualcomm.com/ >> >> Changes in v8: >> - Reordered regulator nodes to maintain alphabetical consistency (Dmitry) >> - Place wifi@0 node under existing pcieport0 label >> - Link to v7: https://lore.kernel.org/all/20260119090758.2780678-1-wei.zhang@oss.qualcomm.com/ >> >> Changes in v7: >> - Align regulator node names to match the existing naming style in the dts (Dmitry) >> - Link to v6: https://lore.kernel.org/all/20260119080125.2761623-1-wei.zhang@oss.qualcomm.com/ >> >> Changes in v6: >> - Rebase patches >> - Remove unintended 'output-low' from wlan-en-state pinctrl (Konrad) >> - Link to v5: https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/ >> >> Changes in v5: >> - Rebase patches >> - Flip the order of property-n and property-names (Konrad) >> - Flip the order of bias and output property (Konrad) >> - Link to v4: https://lore.kernel.org/all/20250325075331.1662306-1-quic_stonez@quicinc.com/ >> >> Changes in v4: >> - Rename the symbol pcieport0 to pcie0_port0 (Konrad) >> - Adjust the property order in node pcie0_port0 (Konrad) >> - Add to the commit message mentioning FW and BDF used by QCS8300 (Dmitry) >> - Specify the calibration data using the correct variant (Dmitry) >> - Link to v3: https://lore.kernel.org/all/20250318093350.2682132-1-quic_stonez@quicinc.com/ >> >> Changes in v3: >> - Complete the nodes property definitions according to DTS binding requirements (Bjorn) >> - Link to v2: https://lore.kernel.org/all/20250227065439.1407230-1-quic_stonez@quicinc.com/ >> >> Changes in v2: >> - Rename the nodes name according to DTS coding style (Konrad & Krzysztof) >> - Provide regulator-min/max-microvolt to the regulators (Konrad) >> - Link to v1: https://lore.kernel.org/all/20250210062910.3618336-1-quic_stonez@quicinc.com/ >> --- >> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 105 ++++++++++++++++++++++ >> 1 file changed, 105 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >> index 68691f7b5f94..864b32503d29 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >> @@ -24,6 +24,26 @@ chosen { >> stdout-path = "serial0:115200n8"; >> }; >> >> + vreg_conn_1p8: regulator-conn-1p8 { >> + compatible = "regulator-fixed"; >> + regulator-name = "vreg_conn_1p8"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + startup-delay-us = <4000>; >> + enable-active-high; >> + gpio = <&pmm8650au_1_gpios 4 GPIO_ACTIVE_HIGH>; >> + }; >> + >> + vreg_conn_pa: regulator-conn-pa { >> + compatible = "regulator-fixed"; >> + regulator-name = "vreg_conn_pa"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + startup-delay-us = <4000>; >> + enable-active-high; >> + gpio = <&pmm8650au_1_gpios 6 GPIO_ACTIVE_HIGH>; >> + }; >> + >> regulator-usb2-vbus { >> compatible = "regulator-fixed"; >> regulator-name = "USB2_VBUS"; >> @@ -33,6 +53,68 @@ regulator-usb2-vbus { >> enable-active-high; >> regulator-always-on; >> }; >> + >> + wcn6855-pmu { >> + compatible = "qcom,wcn6855-pmu"; >> + >> + pinctrl-0 = <&wlan_en_state>; >> + pinctrl-names = "default"; >> + >> + vddio-supply = <&vreg_conn_pa>; >> + vddaon-supply = <&vreg_conn_1p8>; >> + vddpmu-supply = <&vreg_conn_pa>; >> + vddpmumx-supply = <&vreg_conn_1p8>; >> + vddpmucx-supply = <&vreg_conn_pa>; >> + vddrfa0p95-supply = <&vreg_conn_1p8>; > How comes that 0.95V pin is powred on by 1.8V? How comes that 1.3V > pin is powered on by 1.8V? On this platform, all power domains of the WLAN module are enabled through external buck converters controlled by PMIC GPIO4. PMIC‑C GPIO_4 is used for DBU3 ENABLE (PWR_CTRL2_VDD_1P8), and it is also used to enable the core voltages required by the WLAN card (1.95 V, 1.35 V, 1.05 V. etc). Do we also need to define a regulator for vddrfa1p3-supply, vddrfa1p9-supply, vddrfa0p95-supply, etc? > >> + vddrfa1p3-supply = <&vreg_conn_pa>; >> + vddrfa1p9-supply = <&vreg_conn_1p8>; >> + vddpcie1p3-supply = <&vreg_conn_pa>; >> + vddpcie1p9-supply = <&vreg_conn_1p8>; >> + >> + wlan-enable-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>; >> +