From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Andy Whitcroft <apw@canonical.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Spurious warning in checkpatch.pl?
Date: Fri, 12 Oct 2012 11:38:34 -0700 [thread overview]
Message-ID: <1350067114.2243.35.camel@joe-AO722> (raw)
In-Reply-To: <5078603C.9010709@lwfinger.net>
On Fri, 2012-10-12 at 13:23 -0500, Larry Finger wrote:
> Andy,
>
> The checkpatch.pl version in mainline is issuing what I think are false warnings
> of the type
>
> WARNING: networking block comments put the trailing */ on a separate line
> #93: FILE: drivers/net/wireless/rtlwifi/wifi.h:208:
> + u32 rf_rb; /* rflssi_readback */
>
> Is a trailing comment for the member of a struct not allowed?
It's allowed. Maybe even better, encouraged.
It's a change I made in commit 058806007450
("checkpatch: check networking specific block comment style")
without sufficient testing.
I'll see about fixing it.
next prev parent reply other threads:[~2012-10-12 18:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 18:23 Larry Finger
2012-10-12 18:38 ` Joe Perches [this message]
2012-10-12 19:49 ` Larry Finger
2012-10-12 20:01 ` Joe Perches
2012-10-14 19:35 ` [PATCH] checkpatch: Improve network block comment style checking Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350067114.2243.35.camel@joe-AO722 \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®