From: Dmitry Fleytman <dmitry@daynix.com>
To: linux-kernel@vger.kernel.org
Cc: e1000-devel@lists.sourceforge.net,
Chris Webb <chris.webb@elastichosts.com>,
Richard Davies <richard.davies@elastichosts.com>,
Dmitry Fleytman <dmitry@daynix.com>
Subject: [PATCH] e1000 driver RX race condition fixed
Date: Sun, 14 Oct 2012 19:19:10 +0200 [thread overview]
Message-ID: <1350235151-11146-1-git-send-email-dmitry@daynix.com> (raw)
There is a race condition in e1000 driver.
It enables HW receive before RX rings initalization.
In case of specific timing this may lead to host memory corruption
due to DMA write to arbitrary memory location.
Following patch fixes this issue by reordering initialization steps.
Other Intel network drivers does not seem to have this issue.
Dmitry Fleytman (1):
RX initialization sequence fixed - enable RX after corresponding ring
initialization only
drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 9 +++++----
drivers/net/ethernet/intel/e1000/e1000_main.c | 18 ++++++++++++++++--
2 files changed, 21 insertions(+), 6 deletions(-)
--
1.7.9.5
next reply other threads:[~2012-10-14 17:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 17:19 Dmitry Fleytman [this message]
2012-10-14 17:19 ` [PATCH] RX initialization sequence fixed - enable RX after corresponding ring initialization only Dmitry Fleytman
2012-10-15 5:52 ` [E1000-devel] " Jeff Kirsher
2012-10-15 17:41 ` Dmitry Fleytman
2012-10-19 19:19 ` Richard Davies
2012-10-19 19:34 ` Dmitry Fleytman
2012-10-23 5:23 ` Jeff Kirsher
2012-10-15 18:53 ` [PATCH] e1000 driver RX race condition fixed Alexander Duyck
2012-10-15 19:44 ` Dmitry Fleytman
2012-10-15 20:03 ` Alexander Duyck
2012-10-15 20:20 ` Dmitry Fleytman
2012-10-15 21:17 ` Alexander Duyck
2012-10-17 17:46 ` Jan Ceuleers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350235151-11146-1-git-send-email-dmitry@daynix.com \
--to=dmitry@daynix.com \
--cc=chris.webb@elastichosts.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.davies@elastichosts.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®