From: Joe Perches <joe@perches.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@sisk.pl, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
patches@linaro.org, pdsw-power-team@arm.com
Subject: Re: [PATCH 1/2] cpufreq: Improve debug prints
Date: Tue, 16 Oct 2012 23:04:36 -0700 [thread overview]
Message-ID: <1350453876.3072.23.camel@joe-AO722> (raw)
In-Reply-To: <CAKohpo=LL+wPcb97KNQvHbX0fzhnRBZjPsHXTj1PdYObuVVTgw@mail.gmail.com>
On Wed, 2012-10-17 at 11:25 +0530, Viresh Kumar wrote:
> On 17 October 2012 11:09, Joe Perches <joe@perches.com> wrote:
> > On Wed, 2012-10-17 at 10:50 +0530, Viresh Kumar wrote:
> >> With debug options on, it is difficult to locate cpufreq core's debug prints.
> > []
> >> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > []
> >> @@ -15,6 +15,8 @@
> >> +#define pr_fmt(fmt) "cpufreq: " fmt
[]
> > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> Sorry, i am not sure how KBUILD_MODNAME is compiled by kernel.
KBUILD_MODNAME is a #define that is set by scripts/Makefile.lib.
> So, if i try KBUILD_MODNAME with my patch i get prints as:
>
> KBUILD_MODNAME: <print - text>
I believe you are quoting KBUILD_MODNAME
try
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
This should create prefixes like
"cpufreq: "
and
"cpufreq_performance: "
next prev parent reply other threads:[~2012-10-17 6:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 5:20 Viresh Kumar
2012-10-17 5:20 ` [PATCH 2/2] cpufreq: Debugging options for the cpufreq subsystem Viresh Kumar
2012-10-17 9:20 ` Sudeep KarkadaNagesha
2012-10-17 5:39 ` [PATCH 1/2] cpufreq: Improve debug prints Joe Perches
2012-10-17 5:55 ` Viresh Kumar
2012-10-17 6:04 ` Joe Perches [this message]
2012-10-17 6:17 ` Viresh Kumar
2012-10-17 6:26 ` Joe Perches
2012-10-17 6:33 ` Viresh Kumar
2012-10-17 6:39 ` Joe Perches
2012-10-24 22:00 ` Rafael J. Wysocki
2012-10-17 9:25 ` Sudeep KarkadaNagesha
2012-10-17 9:39 ` Viresh Kumar
2012-10-17 9:58 ` Sudeep KarkadaNagesha
2012-10-17 10:23 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350453876.3072.23.camel@joe-AO722 \
--to=joe@perches.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=pdsw-power-team@arm.com \
--cc=rjw@sisk.pl \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®